feat: Make the enable_nat_gateway and single_nat_gateway variables configurable #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chtakahashi
changed the title
chtakahashi
changed the title
|
Noted the pre-commit / min tf pre-commit is failing due to incompatible versions - this was unrelated to the changes I made. Looking for guidance on how to proceed here! 😃 |
3 tasks
bryantbiggs
approved these changes
May 12, 2023
antonbabenko
pushed a commit
that referenced
this pull request
May 12, 2023
## [3.28.0](v3.27.0...v3.28.0) (2023-05-12) ### Features * Make the enable_nat_gateway and single_nat_gateway variables configurable ([#343](#343)) ([375a926](375a926))
|
This PR is included in version 3.28.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our team recently received an email from AWS recommending the utilization of separate NAT Gateways per AZ, and we tracked down the VPC / NAT Gateway combinations to be coming from our usage of the atlantis module.
This PR adds variables to configure the arguments
enable_nat_gatewayandsingle_nat_gatewayto theterraform-aws-modules/vpc/awssubmodule.Motivation and Context
This change is in direct response to the following message we received from AWS, via e-mail:
Breaking Changes
No changes. All new variables are optional, and I set the newly added variables to default to the same initial values as before.
How Has This Been Tested?
We are using this in our own AWS environment.