-
-
Notifications
You must be signed in to change notification settings - Fork 355
feat: Add path option to IAM roles created under this module #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ce to allow a path for accounts that need to specify paths over the defaul '/'. Added that variable to variables.tf and tested the deployment with perms boundary and updated path variable set via module in an existing AWS account
… path options set
…o options for permsissions boundary and the path variable option added in my previous commit
@sf-walsh Please fix the failing GH Actions checks. |
…form_docs and tflint)
@antonbabenko Corrected and pushed with checks passing... Terraform fmt............................................................Passed |
@antonbabenko Not sure if you can direct me at what is wrong... i ran the pre-commit on all files, i ran terraform validate manually.
|
Thank you @sf-walsh ! |
## [3.22.0](v3.21.0...v3.22.0) (2022-10-13) ### Features * Add path option to IAM roles created under this module ([#311](#311)) ([fe833a0](fe833a0))
This PR is included in version 3.22.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add
path
variable to main.tf for resourceaws_iam_role.ecs_task_execution
to allow for creating this role under more than the default path/
Motivation and Context
This resolves an issue for accounts that don't allow creation of roles under the default "/" path. Like permissions_boundary the path is needed if governance rules only allow IAM role creation under
/mycustomrole/path/
Breaking Changes
No
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request