Skip to content

feat: Add permissions to access repository credentials to ecs_task_access_secrets #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 3, 2022
Merged

feat: Add permissions to access repository credentials to ecs_task_access_secrets #306

merged 14 commits into from
Nov 3, 2022

Conversation

szesch
Copy link
Contributor

@szesch szesch commented Aug 12, 2022

Description

Add the credentialsParameter arn to the ecs_task_access_secrets policy if var.repository_credentials is not null and the credentialsParameter key exists in var.repository_credentials.

Motivation and Context

Without this change the access to this secret must be created outside the module and the policy must be passed in via policies_arn. Other parameters are currently granted access but credentialsParameter is an outlier.

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

This change was tested internally with credentialsParemeter configured and without.

@szesch szesch changed the title add repository credentials to ecs_task_access_secrets feat: add repository credentials to ecs_task_access_secrets Aug 12, 2022
@szesch szesch changed the title feat: add repository credentials to ecs_task_access_secrets feat: Add repository credentials to ecs_task_access_secrets Aug 12, 2022
@github-actions
Copy link

github-actions bot commented Oct 8, 2022

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Oct 8, 2022
@szesch
Copy link
Contributor Author

szesch commented Oct 8, 2022

Still relevant

@github-actions github-actions bot removed the stale label Oct 9, 2022
dynamike
dynamike suggested changes Oct 14, 2022
View reviewed changes
Copy link
Member

@dynamike dynamike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me and I'm not sure how folks were able to get this to work with private container repos before. I made one suggestion to use try instead of can, but otherwise this looks good!

@bryantbiggs @dynamike
Update main.tf
4e2232b 
Co-authored-by: Michael Kania <[email protected]>
dynamike
dynamike reviewed Oct 14, 2022
View reviewed changes
Copy link
Member

@dynamike dynamike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like just a spacing issue from terraform fmt. @bryantbiggs Let me know if you need me to help push this through.

@dynamike
Copy link
Member

dynamike commented Nov 1, 2022

@szesch I put up szesch#2 to fix the pre-commit issues so we can get this merged.

@dynamike
Copy link
Member

dynamike commented Nov 1, 2022

@szesch Oops, I fat fingered one bit, so I've got one more for you. szesch#3

@dynamike
Copy link
Member

dynamike commented Nov 2, 2022

@szesch I think all you need is to pull in changes from the base branch and this will be good to merge.

bryantbiggs
bryantbiggs reviewed Nov 3, 2022
View reviewed changes
@bryantbiggs bryantbiggs changed the title feat: Add repository credentials to ecs_task_access_secrets feat: Add permissions to access repository credentials to ecs_task_access_secrets Nov 3, 2022
@bryantbiggs bryantbiggs merged commit 15e9d9b into terraform-aws-modules:master Nov 3, 2022
antonbabenko pushed a commit that referenced this pull request Nov 3, 2022
@semantic-release-bot
chore(release): version 3.24.0 [skip ci]
8bbd4cf 
## [3.24.0](v3.23.1...v3.24.0) (2022-11-03)

### Features

* Add permissions to access repository credentials to `ecs_task_access_secrets` ([#306](#306)) ([15e9d9b](15e9d9b))
@antonbabenko
Copy link
Member

This PR is included in version 3.24.0 🎉

@szesch szesch deleted the repo-creds-access branch November 3, 2022 20:06
@github-actions
Copy link

github-actions bot commented Dec 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dynamike dynamike dynamike requested changes

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@szesch @dynamike @antonbabenko @bryantbiggs