Skip to content

feat: Add arguments in EFS file system #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 21, 2022
Merged

feat: Add arguments in EFS file system #294

merged 3 commits into from
Sep 21, 2022

Conversation

titanlien
Copy link
Contributor

@titanlien titanlien commented Jun 22, 2022 •
edited
Loading

Description

  1. Be able to import EFS file system created by the other terraform module

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@titanlien titanlien changed the title Argument efs file system feat: Add arguments in EFS file system Jun 22, 2022
@titanlien titanlien force-pushed the argument-efs-file-system branch from 7f8797f to d85a1b7 Compare June 28, 2022 14:24
@titanlien titanlien force-pushed the argument-efs-file-system branch from d85a1b7 to 5808cb5 Compare July 24, 2022 16:26
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Aug 24, 2022
bryantbiggs
bryantbiggs reviewed Aug 24, 2022
View reviewed changes
@bryantbiggs
Copy link
Member

@titanlien it looks like I can't update your branch - could you please take a look at the change above and update with master, then we should be able to merge

@bryantbiggs bryantbiggs added wip and removed stale labels Aug 24, 2022
@titanlien
Copy link
Contributor Author

Hi @cytopia I believe you can fetch this upstream and update our PR again.

@snovikov
Copy link
Contributor

@bryantbiggs updated

bryantbiggs
bryantbiggs approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@bryantbiggs bryantbiggs merged commit 089eb6c into terraform-aws-modules:master Sep 21, 2022
antonbabenko pushed a commit that referenced this pull request Sep 21, 2022
@semantic-release-bot
chore(release): version 3.20.0 [skip ci]
4de8562 
## [3.20.0](v3.19.0...v3.20.0) (2022-09-21)

### Features

* Add arguments in EFS file system ([#294](#294)) ([089eb6c](089eb6c))
@antonbabenko
Copy link
Member

This PR is included in version 3.20.0 🎉

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
@snovikov snovikov deleted the argument-efs-file-system branch February 14, 2023 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@titanlien @bryantbiggs @snovikov @antonbabenko