Skip to content

fix: Fix the GitHub Complete example #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 9, 2022
Merged

fix: Fix the GitHub Complete example #277

merged 4 commits into from
May 9, 2022

Conversation

skalinets
Copy link
Contributor

@skalinets skalinets commented May 6, 2022 •
edited
Loading

Description

The GitHub Complete example is broken because of #253. This PR fixes it.

Motivation and Context

I spend few hour trying to provision the Atlantis to Fargate with no luck. Then I found #253 and realised what was the issue. With these fixes everything executed without errors.

Breaking Changes

This PR touches only examples folder, so I don't think it will introduce any breaking change.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* project
  • I have executed pre-commit run -a on my pull request

@skalinets skalinets changed the title Fix the GitHub Complete example fix: Fix the GitHub Complete example May 6, 2022
antonbabenko
antonbabenko requested changes May 6, 2022
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you also add github_repo_names into terraform.tfvars.sample?

@skalinets skalinets changed the title fix: Fix the GitHub Complete example wip: fix: Fix the GitHub Complete example May 8, 2022
@skalinets
Copy link
Contributor Author

I also noticed that despite the webhook has been created, when PR change is made Atlantis posts the following comment:

Error: This repo is not allowlisted for Atlantis.

Will investigate and fix.

@skalinets skalinets force-pushed the fix-github-example branch from 85a9831 to caddff2 Compare May 8, 2022 15:42
@skalinets skalinets changed the title wip: fix: Fix the GitHub Complete example fix: Fix the GitHub Complete example May 8, 2022
@skalinets
Copy link
Contributor Author

Looks good. Could you also add github_repo_names into terraform.tfvars.sample?

done.

I fixed issue with the error message. There is an obvious ambiguity in the meaning of atlantis_repo_allowlist in different modules as discussed in #253, I think this one should be renamed to github_repos or something. However I'd prefer to limit the scope of this PR to the examples directory :)

@skalinets skalinets requested a review from antonbabenko May 8, 2022 19:56
@antonbabenko antonbabenko merged commit 47bd5d4 into terraform-aws-modules:master May 9, 2022
antonbabenko pushed a commit that referenced this pull request May 9, 2022
@semantic-release-bot
chore(release): version 3.15.1 [skip ci]
8fc5c8b 
### [3.15.1](v3.15.0...v3.15.1) (2022-05-09)

### Bug Fixes

* Fix the GitHub complete example ([#277](#277)) ([47bd5d4](47bd5d4))
@antonbabenko
Copy link
Member

This PR is included in version 3.15.1 🎉

titanlien pushed a commit to Flaconi/terraform-aws-atlantis that referenced this pull request Jun 8, 2022
@skalinets
fix: Fix the GitHub complete example (terraform-aws-modules#277)
1851830
titanlien pushed a commit to Flaconi/terraform-aws-atlantis that referenced this pull request Jun 8, 2022
@semantic-release-bot
chore(release): version 3.15.1 [skip ci]
4e2ace0 
### [3.15.1](terraform-aws-modules/terraform-aws-atlantis@v3.15.0...v3.15.1) (2022-05-09)

### Bug Fixes

* Fix the GitHub complete example ([terraform-aws-modules#277](terraform-aws-modules#277)) ([47bd5d4](terraform-aws-modules@47bd5d4))
titanlien pushed a commit to Flaconi/terraform-aws-atlantis that referenced this pull request Jun 8, 2022
@skalinets
fix: Fix the GitHub complete example (terraform-aws-modules#277)
f14774a
titanlien pushed a commit to Flaconi/terraform-aws-atlantis that referenced this pull request Jun 8, 2022
@semantic-release-bot
chore(release): version 3.15.1 [skip ci]
8623a21 
### [3.15.1](terraform-aws-modules/terraform-aws-atlantis@v3.15.0...v3.15.1) (2022-05-09)

### Bug Fixes

* Fix the GitHub complete example ([terraform-aws-modules#277](terraform-aws-modules#277)) ([47bd5d4](terraform-aws-modules@47bd5d4))
titanlien pushed a commit to Flaconi/terraform-aws-atlantis that referenced this pull request Jun 9, 2022
@skalinets
fix: Fix the GitHub complete example (terraform-aws-modules#277)
e96cc55
titanlien pushed a commit to Flaconi/terraform-aws-atlantis that referenced this pull request Jun 9, 2022
@semantic-release-bot
chore(release): version 3.15.1 [skip ci]
17ed3bc 
### [3.15.1](terraform-aws-modules/terraform-aws-atlantis@v3.15.0...v3.15.1) (2022-05-09)

### Bug Fixes

* Fix the GitHub complete example ([terraform-aws-modules#277](terraform-aws-modules#277)) ([47bd5d4](terraform-aws-modules@47bd5d4))
@snovikov snovikov mentioned this pull request Aug 5, 2022
Closed
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko Awaiting requested review from antonbabenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skalinets @antonbabenko