feat: Add IPv6 support (ALB and Route53 AAAA record) #256

bodgit · 2022-02-15T00:46:03Z

Description

This PR enables IPv6 support for the VPC, ALB and adds a AAAA Route53 record.

Motivation and Context

I need to run Atlantis with IPv6 connectivity. I manage the VPC outside of this module so that already has IPv6 enabled so primarily I just needed to change the ALB to "dualstack" and add the AAAA record. I've added additional variables so if the VPC is managed by this module the same configuration can be achieved.

Breaking Changes

None. The new enable_ipv6 variable defaults to false so existing IPv4-only behaviour is preserved.

How Has This Been Tested?

I have tested and validated these changes using one or more of the provided examples/* projects
This will perhaps need a new example?

bryantbiggs · 2022-02-18T14:06:57Z

I think we can add the AAAA record, but if users want to use IPv6 then I think they should use an externally created VPC module otherwise we're slowly going to pull in that entire module here

bodgit · 2022-02-18T14:26:41Z

I think we can add the AAAA record, but if users want to use IPv6 then I think they should use an externally created VPC module otherwise we're slowly going to pull in that entire module here

That's what I'm doing anyway. I was managing the AAAA record separately too, the only necessary feature really is to be able to set the ALB ip_address_type attribute to "dualstack".

Should I just reduce the PR to exposing an alb_ip_address_type variable and then make the AAAA record conditional on that being set to "dualstack"?

bryantbiggs · 2022-02-18T14:29:38Z

main.tf

@@ -234,6 +242,8 @@ module "alb" {
    prefix  = var.alb_log_location_prefix
  }

+  ip_address_type = var.enable_ipv6 ? "dualstack" : "ipv4"


ya lets just make this

Suggested change

ip_address_type = var.enable_ipv6 ? "dualstack" : "ipv4"

ip_address_type = var.alb_ip_address_type

And the variable default will be "ipv4" like the ALB module does

bryantbiggs · 2022-02-18T14:30:34Z

main.tf

@@ -421,6 +431,20 @@ resource "aws_route53_record" "atlantis" {
  }
 }

+resource "aws_route53_record" "atlantis-AAAA" {
+  count = var.create_route53_record && var.enable_ipv6 ? 1 : 0


we can simplify and do

Suggested change

count = var.create_route53_record && var.enable_ipv6 ? 1 : 0

count = var.create_route53_aaaa_record ? 1 : 0

bryantbiggs · 2022-02-18T14:31:24Z

I think we can add the AAAA record, but if users want to use IPv6 then I think they should use an externally created VPC module otherwise we're slowly going to pull in that entire module here

That's what I'm doing anyway. I was managing the AAAA record separately too, the only necessary feature really is to be able to set the ALB ip_address_type attribute to "dualstack".

Should I just reduce the PR to exposing an alb_ip_address_type variable and then make the AAAA record conditional on that being set to "dualstack"?

ya see the two comments above, and then we can just drop the VPC module changes from here

bryantbiggs

looks good to me - what do you think @antonbabenko

antonbabenko

Also, please update the docs (run pre-commit run -a and commit changes).

antonbabenko · 2022-02-18T16:02:40Z

main.tf

@@ -421,6 +423,20 @@ resource "aws_route53_record" "atlantis" {
  }
 }

+resource "aws_route53_record" "atlantis-AAAA" {


Suggested change

resource "aws_route53_record" "atlantis-AAAA" {

resource "aws_route53_record" "atlantis_aaaa" {

lowercase and _

bodgit · 2022-02-18T17:15:48Z

I was wondering how you ran terraform-docs, that answers that 😄

Docs updated.

antonbabenko

Just a minor comment before merging.

variables.tf

github-actions · 2022-03-21T00:09:18Z

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions · 2022-04-01T00:10:12Z

This PR was automatically closed because of stale in 10 days

bodgit · 2022-04-01T16:33:03Z

@bryantbiggs @antonbabenko can this be reopened and merged please? I'm not aware of any outstanding issues with it

(I really hate stale bots)

antonbabenko · 2022-04-01T19:07:33Z

@bodgit Apologies for the delay with this PR. Mentioning my username when something has been finished helps me a lot!

## [3.14.0](v3.13.1...v3.14.0) (2022-04-01) ### Features * Add IPv6 support (ALB and Route53 AAAA record) ([#256](#256)) ([6cefda0](6cefda0))

antonbabenko · 2022-04-01T19:13:39Z

This PR is included in version 3.14.0 🎉

…odules#256)

## [3.14.0](terraform-aws-modules/terraform-aws-atlantis@v3.13.1...v3.14.0) (2022-04-01) ### Features * Add IPv6 support (ALB and Route53 AAAA record) ([terraform-aws-modules#256](terraform-aws-modules#256)) ([6cefda0](terraform-aws-modules@6cefda0))

…odules#256)

## [3.14.0](terraform-aws-modules/terraform-aws-atlantis@v3.13.1...v3.14.0) (2022-04-01) ### Features * Add IPv6 support (ALB and Route53 AAAA record) ([terraform-aws-modules#256](terraform-aws-modules#256)) ([6cefda0](terraform-aws-modules@6cefda0))

…odules#256)

## [3.14.0](terraform-aws-modules/terraform-aws-atlantis@v3.13.1...v3.14.0) (2022-04-01) ### Features * Add IPv6 support (ALB and Route53 AAAA record) ([terraform-aws-modules#256](terraform-aws-modules#256)) ([6cefda0](terraform-aws-modules@6cefda0))

github-actions · 2022-11-08T02:34:10Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

bodgit changed the title ~~Add IPv6 support~~ feat: Add IPv6 support Feb 15, 2022

bryantbiggs reviewed Feb 18, 2022

View reviewed changes

bodgit force-pushed the ipv6 branch from 9f62e8c to d9cbed8 Compare February 18, 2022 14:44

bryantbiggs approved these changes Feb 18, 2022

View reviewed changes

antonbabenko reviewed Feb 18, 2022

View reviewed changes

bodgit force-pushed the ipv6 branch from d9cbed8 to 1a9b63b Compare February 18, 2022 17:14

antonbabenko requested changes Feb 18, 2022

View reviewed changes

variables.tf Outdated Show resolved Hide resolved

Add IPv6 support

b14d0e9

bodgit force-pushed the ipv6 branch from 1a9b63b to b14d0e9 Compare February 18, 2022 20:12

github-actions bot added the stale label Mar 21, 2022

github-actions bot closed this Apr 1, 2022

antonbabenko reopened this Apr 1, 2022

antonbabenko added 2 commits April 1, 2022 21:07

Merge branch 'master' into ipv6

d3c6c95

Fixed docs

3e1dd45

antonbabenko changed the title ~~feat: Add IPv6 support~~ feat: Add IPv6 support (ALB and Route53 AAAA record) Apr 1, 2022

antonbabenko merged commit 6cefda0 into terraform-aws-modules:master Apr 1, 2022

antonbabenko pushed a commit that referenced this pull request Apr 1, 2022

chore(release): version 3.14.0 [skip ci]

fab764c

## [3.14.0](v3.13.1...v3.14.0) (2022-04-01) ### Features * Add IPv6 support (ALB and Route53 AAAA record) ([#256](#256)) ([6cefda0](6cefda0))

bodgit deleted the ipv6 branch April 4, 2022 20:07

titanlien pushed a commit to Flaconi/terraform-aws-atlantis that referenced this pull request Jun 8, 2022

feat: Add IPv6 support (ALB and Route53 AAAA record) (terraform-aws-m…

380dd98

…odules#256)

titanlien pushed a commit to Flaconi/terraform-aws-atlantis that referenced this pull request Jun 8, 2022

feat: Add IPv6 support (ALB and Route53 AAAA record) (terraform-aws-m…

16153ad

…odules#256)

titanlien pushed a commit to Flaconi/terraform-aws-atlantis that referenced this pull request Jun 9, 2022

feat: Add IPv6 support (ALB and Route53 AAAA record) (terraform-aws-m…

ce14f23

…odules#256)

github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add IPv6 support (ALB and Route53 AAAA record) #256

feat: Add IPv6 support (ALB and Route53 AAAA record) #256

bodgit commented Feb 15, 2022

bryantbiggs commented Feb 18, 2022

bodgit commented Feb 18, 2022

bryantbiggs Feb 18, 2022

bryantbiggs Feb 18, 2022

bryantbiggs commented Feb 18, 2022

bryantbiggs left a comment

antonbabenko left a comment

antonbabenko Feb 18, 2022

bodgit commented Feb 18, 2022

antonbabenko left a comment

github-actions bot commented Mar 21, 2022

github-actions bot commented Apr 1, 2022

bodgit commented Apr 1, 2022

antonbabenko commented Apr 1, 2022 •

edited

Loading

antonbabenko commented Apr 1, 2022

github-actions bot commented Nov 8, 2022

	ip_address_type = var.enable_ipv6 ? "dualstack" : "ipv4"
	ip_address_type = var.alb_ip_address_type

	count = var.create_route53_record && var.enable_ipv6 ? 1 : 0
	count = var.create_route53_aaaa_record ? 1 : 0

	resource "aws_route53_record" "atlantis-AAAA" {
	resource "aws_route53_record" "atlantis_aaaa" {

feat: Add IPv6 support (ALB and Route53 AAAA record) #256

feat: Add IPv6 support (ALB and Route53 AAAA record) #256

Conversation

bodgit commented Feb 15, 2022

Description

Motivation and Context

Breaking Changes

How Has This Been Tested?

bryantbiggs commented Feb 18, 2022

bodgit commented Feb 18, 2022

bryantbiggs Feb 18, 2022

Choose a reason for hiding this comment

bryantbiggs Feb 18, 2022

Choose a reason for hiding this comment

bryantbiggs commented Feb 18, 2022

bryantbiggs left a comment

Choose a reason for hiding this comment

antonbabenko left a comment

Choose a reason for hiding this comment

antonbabenko Feb 18, 2022

Choose a reason for hiding this comment

bodgit commented Feb 18, 2022

antonbabenko left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 21, 2022

github-actions bot commented Apr 1, 2022

bodgit commented Apr 1, 2022

antonbabenko commented Apr 1, 2022 • edited Loading

antonbabenko commented Apr 1, 2022

github-actions bot commented Nov 8, 2022

antonbabenko commented Apr 1, 2022 •

edited

Loading