feat: Add base URL for GitHub Enterprise #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| variable "github_base_url" { | ||
| description = "Github base URL to use when creating webhook (when using GitHub Enterprise)" | ||
| type = string | ||
| default = "" |
There was a problem hiding this comment.
Suggested change
| default = "" | |
| default = null |
Accoding to the docs for base_url it is optional, so it should be null.
There was a problem hiding this comment.
Ah, sorry about that and thanks for suggestion!
There was a problem hiding this comment.
Also, please fix the docs (to make CI green).
DoomHammer
force-pushed
the
feat/add-base-url
branch
from
637220c to
edc2d8e
Compare
DoomHammer
force-pushed
the
feat/add-base-url
branch
from
edc2d8e to
0b65204
Compare
antonbabenko
pushed a commit
that referenced
this pull request
Jan 17, 2022
## [3.7.0](v3.6.0...v3.7.0) (2022-01-17) ### Features * Add base URL for GitHub Enterprise ([#244](#244)) ([4195ea2](4195ea2))
|
This PR is included in version 3.7.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add base URL for use with GitHub Enterprise.
Motivation and Context
Currently, the only way to use the module with GItHub Enterprise is via injecting the provider configuration. However, in recent versions of Terraform,
terraform validatewill treat it as an error. Adding a variable solves this issue.Breaking Changes
No known.
How Has This Been Tested?
examples/*projects