feat: allow adding more trusted principals to task role #155
Conversation
At the moment, the only trusted entity to assume the task role is the absolute minimum ecs-tasks.amazonaws.com However sometimes it's convenient to add more principals. For example in order to allow easy SSM access into the Fargate task, ssm.amazonaws.com should be trusted too. This commit allows module users to optionally define extra principals that can assume the task role.
|
Hi @antonbabenko 👋 Is it possible for me to change this Any help would be appreciated thanks! |
|
Should work like this - |
|
@antonbabenko are you waiting anything from me on this or can we merge please? |
|
Thanks! v2.27.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Extra input variable to allow module users to optionally define extra principals that can assume the task role.
Apart from the main module code and documentation, the example is also updated to showcase how the new variable can be used.
Motivation and Context
At the moment, the only trusted entity to assume the task role is the absolute minimum
ecs-tasks.amazonaws.com.However sometimes it's convenient to allow adding more principals.
For example in order to allow easy SSM access into the Fargate task,
ssm.amazonaws.comshould be trusted too.Breaking Changes
No breaking changes. Just adding an optional input variable.
How Has This Been Tested?
From my project downstream, I have referenced this PR branch and applied my infrastructure. It works as expected.