Skip to content

feat: Use atlantis bot instead of a github user #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 1, 2020

Conversation

nitrocode
Copy link
Member

Description

See https://www.runatlantis.io/docs/access-credentials.html#generating-an-access-token

This is a new feature as of 0.14.0

This PR closes #147

Motivation and Context

It's much better to set this up as a github app instead of a github user as you have an easier interface for granular controls, app can be installed across an org, and app settings can control which repos have access to it.

Breaking Changes

None

How Has This Been Tested?

  1. Destroyed current atlantis
  2. Recreated atlantis
  3. Opened PR
  4. Tested PR using a github app instead of a github user

@nitrocode nitrocode changed the title Use atlantis bot instead of a github user feat: Use atlantis bot instead of a github user Aug 23, 2020
@nitrocode
Copy link
Member Author

nitrocode commented Sep 1, 2020

@antonbabenko friendly ping :)

When you get a chance could you or one of the maintainers review this PR please?

@antonbabenko antonbabenko merged commit 6c54e68 into terraform-aws-modules:master Sep 1, 2020
@antonbabenko
Copy link
Member

Thanks, @nitrocode !

Looks good, I have just released this as v2.24.0

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use atlantis bot instead of a github user
2 participants