feat: Refactor to use SSM ARNs directly from resources #135
Conversation
DrFaust92
changed the title
main.tf
Outdated
| "arn:${var.aws_ssm_path}:ssm:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:parameter${var.atlantis_gitlab_user_token_ssm_parameter_name}", | ||
| "arn:${var.aws_ssm_path}:ssm:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:parameter${var.atlantis_bitbucket_user_token_ssm_parameter_name}", | ||
| ] | ||
| resources = coalescelist( |
There was a problem hiding this comment.
This will find the first non-empty list.
Maybe unrelated question... Is it possible to make this module work for multiple types of VCS at the same time with little or no changes?
There was a problem hiding this comment.
fixed this with bt replacing coalescelist with flatten(list()) this works fine for create. but it didnt seem to work right with update. it only saw diff for update the second run
There was a problem hiding this comment.
to the other question, i don't think so... there are things like secret_name_key that are specific to the input and will default to one of the first parameters that are listed
|
Thanks, @DrFaust92 ! v2.18.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
remove the
aws_ssm_pathvariable to get full proper ARN from SSM resources instead of building it manuallyMotivation and Context
Breaking Changes
NONE
How Has This Been Tested?
Run with the sample tfvars, added the changes and re-run to get no diffs (aside from regular ECS diff)