fix: dont log GitHub app token in logs (runatlantis#4667)

dobby-dobster · tobaker · terakoya76 · commit e25f7ed8258b · 2024-12-31T20:49:54.000+09:00
Co-authored-by: Tom Baker &lt;tobaker@tripadvisor.com&gt;
diff --git a/server/events/vcs/gh_app_creds_rotator.go b/server/events/vcs/gh_app_creds_rotator.go
@@ -61,7 +61,7 @@ func (r *githubAppTokenRotator) rotate() error {
 	if err != nil {
 		return errors.Wrap(err, "Getting github token")
 	}
-	r.log.Debug("token %s", token)
+	r.log.Debug("Token successfully refreshed")
 
 	// https://developer.github.com/apps/building-github-apps/authenticating-with-github-apps/#http-based-git-access-by-an-installation
 	if err := WriteGitCreds("x-access-token", token, r.githubHostname, r.homeDirPath, r.log, true); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ func (r *githubAppTokenRotator) rotate() error {`
`61`	`61`	`if err != nil {`
`62`	`62`	`return errors.Wrap(err, "Getting github token")`
`63`	`63`	`}`
`64`		`- r.log.Debug("token %s", token)`
	`64`	`+ r.log.Debug("Token successfully refreshed")`
`65`	`65`
`66`	`66`	`// https://developer.github.com/apps/building-github-apps/authenticating-with-github-apps/#http-based-git-access-by-an-installation`
`67`	`67`	`if err := WriteGitCreds("x-access-token", token, r.githubHostname, r.homeDirPath, r.log, true); err != nil {`