Add tests to get to 100% branch coverage

theseer · theseer · commit e8088e892122 · 2023-07-26T23:27:24.000+02:00
diff --git a/src/viewmodel/ViewModelRenderer.php b/src/viewmodel/ViewModelRenderer.php
@@ -426,6 +426,10 @@ private function objectApply(DOMElement $context, object $model): void {
                 str_replace(['-', ':'], '', ucwords($attribute->nodeName, '-:'))
             );
 
+            if (in_array($name, ['property','prefix','vocab','resource'])) {
+                continue;
+            }
+
             $result = match (true) {
                 // method variants
                 method_exists($model, $name)         => $model->{$name}($attribute->nodeValue),
diff --git a/tests/_data/viewmodel/prefix/prefixmodel.php b/tests/_data/viewmodel/prefix/prefixmodel.php
@@ -82,3 +82,22 @@ public function __call($method, $args) {
         throw new \RuntimeException('FAIL:' . $method);
     }
 }
+
+class PrefixPropertyViewModel {
+
+    public function __construct(
+        public User $user = new User,
+        public Header $header = new Header
+    ) {}
+}
+
+class PrefixPropertyGetViewModel {
+    public function __get($method) {
+        switch ($method) {
+            case 'user': return new User();
+            case 'header': return new Header();
+        }
+
+        throw new \RuntimeException('FAIL:' . $method);
+    }
+}
diff --git a/tests/_data/viewmodel/resource/resourcemodel.php b/tests/_data/viewmodel/resource/resourcemodel.php
@@ -82,3 +82,23 @@ public function __call($method, $args) {
         throw new \RuntimeException('FAIL:' . $method);
     }
 }
+
+class ResourcePropertyViewModel {
+
+    public function __construct(
+        public User $user = new User,
+        public Header $header = new Header,
+    ) {}
+
+}
+
+class ResourcePropertyGetViewModel {
+    public function __get(string $method) {
+        switch ($method) {
+            case 'user': return new User();
+            case 'header': return new Header();
+        }
+
+        throw new \RuntimeException('FAIL:' . $method);
+    }
+}
diff --git a/tests/document/DocumentTest.php b/tests/document/DocumentTest.php
@@ -9,6 +9,7 @@
  */
 namespace Templado\Engine;
 
+use DOMNode;
 use function libxml_get_errors;
 use ArrayIterator;
 use DOMDocument;
@@ -31,6 +32,7 @@
 #[UsesClass(DocumentCollection::class)]
 #[UsesClass(Signal::class)]
 #[UsesClass(StaticNodeList::class)]
+#[UsesClass(TransformationProcessor::class)]
 class DocumentTest extends TestCase {
     use DomDocumentsEqualTrait;
 
@@ -326,5 +328,43 @@ public function testAsStringResultIsFormattedAsException(): void {
         $this->assertEquals($expected, (Document::fromDomDocument($xml))->asString());
     }
 
+    public function testSelectorGetsUsedWhenViewModelGetsApplied(): void {
+        $target = Document::fromString('<root><child property="handle" /><child property="ignore" /></root>');
+
+        $target->applyViewModel(
+            new class {
+                public string $handle = 'text body';
+            },
+            new XPathSelector('//child[@property="handle"]')
+        );
+
+
+        $dom = new DomDocument();
+        $dom->loadXML('<root><child property="handle">text body</child><child property="ignore" /></root>');
+
+        $this->assertResultMatches($dom->documentElement, $target->asDomDocument()->documentElement);
+    }
+
+    public function testSelectorGetsUsedWhenTransformationGetsApplied(): void {
+        $target = Document::fromString('<root><child property="handle" /><child property="ignore" /></root>');
+
+        $target->applyTransformation(
+            new class implements Transformation {
+                public function selector() : Selector{
+                    return new XPathSelector('self::*');
+                }
+                public function apply(DOMNode $context) : void{
+                    $context->setAttribute('transformation', 'done');
+                }
+            },
+            new XPathSelector('//child[@property="handle"]')
+        );
+
+
+        $dom = new DomDocument();
+        $dom->loadXML('<root><child transformation="done" property="handle" /><child property="ignore" /></root>');
+
+        $this->assertResultMatches($dom->documentElement, $target->asDomDocument()->documentElement);
+    }
 
 }
diff --git a/tests/selectors/XPathSelectorTest.php b/tests/selectors/XPathSelectorTest.php
@@ -22,6 +22,23 @@ public function testSelectReturnsExceptedNode(): void {
         }
     }
 
+    public function testSelectReturnsExceptedNodeWhenDomDocuemtnIsUsed(): void {
+        $dom = new DOMDocument();
+        $dom->loadXML('<?xml version="1.0" ?><root><child /></root>');
+
+        $selector  = new XPathSelector('//child');
+        $selection = $selector->select($dom);
+
+        $this->assertInstanceOf(Selection::class, $selection);
+
+        foreach ($selection as $node) {
+            $this->assertSame(
+                $dom->documentElement->firstChild,
+                $node
+            );
+        }
+    }
+
     public function testRegisteredNamespacePrefixIsUsed(): void {
         $dom = new DOMDocument();
         $dom->loadXML('<?xml version="1.0" ?><root xmlns="foo:ns"><child /></root>');
diff --git a/tests/viewmodel/ViewModelRendererTest.php b/tests/viewmodel/ViewModelRendererTest.php
@@ -10,8 +10,12 @@
 use PHPUnit\Framework\TestCase;
 use Templado\Engine\Example\ViewModel;
 use Templado\Engine\PrefixModel\PrefixCallViewModel;
+use Templado\Engine\PrefixModel\PrefixPropertyGetViewModel;
+use Templado\Engine\PrefixModel\PrefixPropertyViewModel;
 use Templado\Engine\PrefixModel\PrefixViewModel;
 use Templado\Engine\ResourceModel\ResourceCallViewModel;
+use Templado\Engine\ResourceModel\ResourcePropertyGetViewModel;
+use Templado\Engine\ResourceModel\ResourcePropertyViewModel;
 use Templado\Engine\ResourceModel\ResourceViewModel;
 
 #[CoversClass(ViewModelRenderer::class)]
@@ -431,8 +435,8 @@ public function asString() {
         );
     }
 
-    public function testResourceViewModelGetsAppliedAsExcepted(): void {
-        $viewModel               = new ResourceViewModel();
+    #[DataProvider('resourceViewModelProvider')]
+    public function testResourceViewModelGetsAppliedAsExcepted(object $viewModel): void {
         $dom                     = new DOMDocument();
         $dom->preserveWhiteSpace = false;
         $dom->load(__DIR__ . '/../_data/viewmodel/resource/source.html');
@@ -447,20 +451,13 @@ public function testResourceViewModelGetsAppliedAsExcepted(): void {
         $this->assertResultMatches($expected->documentElement, $dom->documentElement);
     }
 
-    public function testResourceViewModelWithMagicCallGetsAppliedAsExcepted(): void {
-        $viewModel               = new ResourceCallViewModel();
-        $dom                     = new DOMDocument();
-        $dom->preserveWhiteSpace = false;
-        $dom->load(__DIR__ . '/../_data/viewmodel/resource/source.html');
-
-        $renderer = new ViewModelRenderer();
-        $renderer->render($dom->documentElement, $viewModel);
-
-        $expected                     = new DOMDocument();
-        $expected->preserveWhiteSpace = false;
-        $expected->load(__DIR__ . '/../_data/viewmodel/resource/expected.html');
-
-        $this->assertResultMatches($expected->documentElement, $dom->documentElement);
+    public static function resourceViewModelProvider(): array {
+        return [
+            'method' => [new ResourceViewModel()],
+            'call' => [new ResourceCallViewModel()],
+            'property' => [new ResourcePropertyViewModel()],
+            'get' => [new ResourcePropertyGetViewModel()]
+        ];
     }
 
     public function testUsingAResourceWithNoMethodToRequestItThrowsException(): void {
@@ -483,8 +480,9 @@ public function testResolvingResourceToNonObjectThrowsException(): void {
         $renderer->render($dom->documentElement, new class { public function foo(): string { return 'crash'; }});
     }
 
-    public function testPrefixViewModelGetsAppliedAsExcepted(): void {
-        $viewModel               = new PrefixViewModel();
+
+    #[DataProvider('prefixViewModelProvider')]
+    public function testPrefixViewModelGetsAppliedAsExcepted(object $viewModel): void {
         $dom                     = new DOMDocument();
         $dom->preserveWhiteSpace = false;
         $dom->load(__DIR__ . '/../_data/viewmodel/prefix/source.html');
@@ -499,6 +497,15 @@ public function testPrefixViewModelGetsAppliedAsExcepted(): void {
         $this->assertResultMatches($expected->documentElement, $dom->documentElement);
     }
 
+    public static function prefixViewModelProvider(): array {
+        return [
+            'method' => [new PrefixViewModel()],
+            'call' => [new PrefixCallViewModel()],
+            'property' => [new PrefixPropertyViewModel()],
+            'get' => [new PrefixPropertyGetViewModel()]
+        ];
+    }
+
     public function testPrefixWithDoubleColonViewModelGetsAppliedAsExcepted(): void {
         $viewModel               = new PrefixViewModel();
         $dom                     = new DOMDocument();
@@ -515,22 +522,6 @@ public function testPrefixWithDoubleColonViewModelGetsAppliedAsExcepted(): void
         $this->assertResultMatches($expected->documentElement, $dom->documentElement);
     }
 
-    public function testPrefixViewModelWithMagicCallGetsAppliedAsExcepted(): void {
-        $viewModel               = new PrefixCallViewModel();
-        $dom                     = new DOMDocument();
-        $dom->preserveWhiteSpace = false;
-        $dom->load(__DIR__ . '/../_data/viewmodel/prefix/source.html');
-
-        $renderer = new ViewModelRenderer();
-        $renderer->render($dom->documentElement, $viewModel);
-
-        $expected                     = new DOMDocument();
-        $expected->preserveWhiteSpace = false;
-        $expected->load(__DIR__ . '/../_data/viewmodel/prefix/expected.html');
-
-        $this->assertResultMatches($expected->documentElement, $dom->documentElement);
-    }
-
     public function testUsingAPrefixWithNoMethodToRequestItThrowsException(): void {
         $dom = new DOMDocument();
         $dom->loadXML('<?xml version="1.0"?><root prefix="p: foo" />');
@@ -1049,4 +1040,57 @@ public function document(): Document {
 
         $this->assertResultMatches($expected->documentElement, $dom->documentElement);
     }
+
+    #[DataProvider('attributeViewModelProvider')]
+    public function testAttributesGetAppliedFromViewModelProperties(object $model, string $value): void {
+        $dom = new DOMDocument();
+        $dom->loadXML('<root property="document" attr="default" />');
+
+        $renderer = new ViewModelRenderer();
+        $renderer->render(
+            $dom->documentElement,
+            $model
+        );
+
+        $expected = new DOMDocument();
+        $expected->loadXML('<root property="document" attr="'.$value.'" />');
+
+        $this->assertResultMatches($expected->documentElement, $dom->documentElement);
+    }
+
+    public static function attributeViewModelProvider(): array {
+        return [
+            'property' => [
+                new class {
+                    public function document(): object {
+                        return new class {
+                            public string $attr='changed';
+                        };
+                    }
+                },
+                'changed'
+            ],
+            'get' => [
+                new class {
+                    public function document(): object {
+                        return new class {
+                            public function __get(string $key): string|true {
+                                return $key === 'attr' ? 'changed' : true;
+                            }
+                        };
+                    }
+                },
+                'changed'
+            ],
+            'none' => [
+                new class {
+                    public function document(): object {
+                        return new class {
+                        };
+                    }
+                },
+                'default'
+            ]
+        ];
+    }
 }
