Update pslam usage

- bump level to 2
- add suppress to shutup about things that are intentional
- add missing type annotations

Author: theseer

build/psalm/baseline.xml

@@ -1,16 +1,8 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="5.13.1@086b94371304750d1c673315321a55d15fc59015">
+<files psalm-version="5.14.1@b9d355e0829c397b9b3b47d0c0ed042a8a70284d">
   <file src="src/formdata/FormDataRenderer.php">
-    <PossiblyInvalidArgument>
-      <code><![CDATA[$form->getValue(
-                        $textarea->getAttribute('name')
-                    )]]></code>
-      <code><![CDATA[$form->getValue(
-                    $name
-                )]]></code>
-      <code><![CDATA[$form->getValue(
-                    $select->getAttribute('name')
-                )]]></code>
-    </PossiblyInvalidArgument>
+    <PossiblyNullReference>
+      <code>createTextNode</code>
+    </PossiblyNullReference>
   </file>
 </files>

psalm.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <psalm
-    errorLevel="3"
+    errorLevel="2"
     resolveFromConfigFile="true"
     totallyTyped="true"
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

psalm.xml.org

@@ -21,6 +21,7 @@
 final class FormData {
     private readonly string $identifier;
 
+    /** @psalm-var array<string,string> */
     private array $values = [];
 
     /**

src/formdata/FormData.php

@@ -14,6 +14,7 @@
 
 class EmptyElementsFilter implements Filter {
     public function apply(string $content): string {
+        /** @psalm-var list<string> */
         static $tagList = [
             'base', 'br', 'meta', 'link', 'img', 'input', 'button', 'hr', 'embed',
             'param', 'source', 'track', 'area', 'keygen',

src/serializer/EmptyElementsFilter.php

@@ -20,8 +20,10 @@ class HTMLSerializer implements Serializer {
 
     private bool $withDoctypeFlag = true;
 
+    /** @psalm-var list<Filter> */
     private array $filters = [];
 
+    /** @psalm-var list<Transformation> */
     private array $transformations = [];
 
     public function stripRDFa(): self {

src/serializer/HTMLSerializer.php

@@ -386,6 +386,7 @@ private function conditionalApply(DOMElement $context, object|iterable $model):
             }
 
             $typeOf = $current->typeOf();
+
             if (!is_string($typeOf)) {
                 throw new ViewModelRendererException(
                     sprintf('Value returned by typeOf() must be string (%s)', $this->getModelPath($context)),
@@ -408,7 +409,7 @@ private function conditionalApply(DOMElement $context, object|iterable $model):
                         $context,
                         $current,
                         'typeOf',
-                        sprintf('No matching types for "%s" found', (string)$typeOf)
+                        sprintf('No matching types for "%s" found', $typeOf)
                     ),
                     ViewModelRendererException::NoMatch
                 );