Skip to content

Commit 1952ecc

Browse files
lx1036tekton-robot
authored andcommitted
Add ImagePullSecrets field when create Deployment by EventListener
Signed-off-by: lx1036 <[email protected]>
1 parent a920e8c commit 1952ecc

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

pkg/apis/triggers/v1beta1/event_listener_validation.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -277,12 +277,12 @@ func podSpecMask(in *corev1.PodSpec) *corev1.PodSpec {
277277
out.NodeSelector = in.NodeSelector
278278
out.Affinity = in.Affinity
279279
out.TopologySpreadConstraints = in.TopologySpreadConstraints
280+
out.ImagePullSecrets = in.ImagePullSecrets
280281

281282
// Disallowed fields
282283
// This list clarifies which all podspec fields are not allowed.
283284
out.Volumes = nil
284285
out.EnableServiceLinks = nil
285-
out.ImagePullSecrets = nil
286286
out.InitContainers = nil
287287
out.RestartPolicy = ""
288288
out.TerminationGracePeriodSeconds = nil

pkg/reconciler/eventlistener/resources/deployment.go

+5
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ func MakeDeployment(ctx context.Context, el *v1beta1.EventListener, configAcc re
8080
nodeSelector, annotations map[string]string
8181
affinity *corev1.Affinity
8282
topologySpreadConstraints []corev1.TopologySpreadConstraint
83+
imagePullSecrets []corev1.LocalObjectReference
8384
)
8485

8586
for _, v := range container.Env {
@@ -106,6 +107,9 @@ func MakeDeployment(ctx context.Context, el *v1beta1.EventListener, configAcc re
106107
if len(el.Spec.Resources.KubernetesResource.Template.Spec.NodeSelector) != 0 {
107108
nodeSelector = el.Spec.Resources.KubernetesResource.Template.Spec.NodeSelector
108109
}
110+
if len(el.Spec.Resources.KubernetesResource.Template.Spec.ImagePullSecrets) != 0 {
111+
imagePullSecrets = el.Spec.Resources.KubernetesResource.Template.Spec.ImagePullSecrets
112+
}
109113
if el.Spec.Resources.KubernetesResource.Template.Spec.ServiceAccountName != "" {
110114
serviceAccountName = el.Spec.Resources.KubernetesResource.Template.Spec.ServiceAccountName
111115
}
@@ -137,6 +141,7 @@ func MakeDeployment(ctx context.Context, el *v1beta1.EventListener, configAcc re
137141
Annotations: annotations,
138142
},
139143
Spec: corev1.PodSpec{
144+
ImagePullSecrets: imagePullSecrets,
140145
Tolerations: tolerations,
141146
NodeSelector: nodeSelector,
142147
ServiceAccountName: serviceAccountName,

0 commit comments

Comments
 (0)