Revert "fix: cronOperator/serverResubmitWf retry create workflow on transient error. Fixes argoproj#13970 (argoproj#13971)"

tczhao · tczhao · commit fdd308ad9bbf · 2025-02-17T12:22:58.000Z
This reverts commit bf81a05.
diff --git a/workflow/util/util.go b/workflow/util/util.go
@@ -193,13 +193,7 @@ func SubmitWorkflow(ctx context.Context, wfIf v1alpha1.WorkflowInterface, wfClie
 		}
 		return wf, err
 	} else {
-		var runWf *wfv1.Workflow
-		err = waitutil.Backoff(retry.DefaultRetry, func() (bool, error) {
-			var err error
-			runWf, err = wfIf.Create(ctx, wf, metav1.CreateOptions{})
-			return !errorsutil.IsTransientErr(err), err
-		})
-		return runWf, err
+		return wfIf.Create(ctx, wf, metav1.CreateOptions{})
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -193,13 +193,7 @@ func SubmitWorkflow(ctx context.Context, wfIf v1alpha1.WorkflowInterface, wfClie`
`193`	`193`	`}`
`194`	`194`	`return wf, err`
`195`	`195`	`} else {`
`196`		`- var runWf *wfv1.Workflow`
`197`		`- err = waitutil.Backoff(retry.DefaultRetry, func() (bool, error) {`
`198`		`- var err error`
`199`		`- runWf, err = wfIf.Create(ctx, wf, metav1.CreateOptions{})`
`200`		`- return !errorsutil.IsTransientErr(err), err`
`201`		`- })`
`202`		`- return runWf, err`
	`196`	`+ return wfIf.Create(ctx, wf, metav1.CreateOptions{})`
`203`	`197`	`}`
`204`	`198`	`}`
`205`	`199`