Skip to content
This repository was archived by the owner on Jan 26, 2022. It is now read-only.

Test262 coverage note #33

Closed
domenic opened this issue Mar 6, 2019 · 1 comment
Closed

Test262 coverage note #33

domenic opened this issue Mar 6, 2019 · 1 comment

Comments

@domenic
Copy link
Member

domenic commented Mar 6, 2019

Reviewing the spec text, I was reminded of the extra care we put in to making Promise.all behave reasonably in the face of weird promise subclasses and similar scenarios, e.g. with the [[AlreadyResolved]] internal slot. I think those are pretty exhaustively tested in existing test262, and this issue is about making sure the same is done for Promise.allSettled.

When writing test262 tests, please be sure to test all the same weird edge cases that can occur as with Promise.all---plus the extra ones introduced by the reject element function and its interactions.

(I'm fine if the champions would like to close this issue and roll it into #11, or move it to the test262 repo. But I'm raising it here for visibility to start with.)

@rpamely
Copy link
Collaborator

rpamely commented Mar 27, 2019

I am going to copy this to the test262 issue and close this. (tc39/test262#2112)

@rpamely rpamely closed this as completed Mar 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants