Skip to content

Commit e3672e7

Browse files
committed
Run Windows test with JDK 8 rather than JDK 11
The initial goal (IIRC) was to make sure that the build could run with JDK 11, but unfortunately this means that on Windows the JDK 8-specific -Xbootclasspath/p is not execised, whereas this is probably the most important thing to test for Windows compatibility, given that it contains file paths. With this change, the build itself (not the code) is no longer exercised against JDK 11, but it doesn't really matter actually.
1 parent bb2c9c7 commit e3672e7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/gradle.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ on:
1111
env:
1212
GRADLE_OPTS: "-Dorg.gradle.daemon=false"
1313

14-
# First build on Linux with JDK 8 and Windows with JDK 11
14+
# First build on Linux and Windows with JDK 8
1515
# Then run tests with various Gradle and JDKs versions (Linux only)
1616
jobs:
1717
linux:
@@ -45,7 +45,7 @@ jobs:
4545
- uses: actions/checkout@v2
4646

4747
- name: Setup environment
48-
run: echo "JAVA_HOME=${Env:JAVA_HOME_11_X64}" | Tee-Object -FilePath $env:GITHUB_ENV -Append
48+
run: echo "JAVA_HOME=${Env:JAVA_HOME_8_X64}" | Tee-Object -FilePath $env:GITHUB_ENV -Append
4949

5050
- name: Build with Gradle
5151
id: gradle-build

0 commit comments

Comments
 (0)