Skip to content

Commit 3fb9753

Browse files
committed
deps: V8: revert e3cddbedb205
simdutf's `atomic_binary_to_base64` requires `std::atomic_ref`. `std::atomic_ref` is only available in LLVM 19, which is only available in Xcode 16.3, which is only available on macOS 15. Refs: llvm/llvm-project#76647 Refs: v8/v8@e3cddbe
1 parent fb56668 commit 3fb9753

File tree

3 files changed

+5
-72
lines changed

3 files changed

+5
-72
lines changed

deps/v8/BUILD.bazel

-6
Original file line numberDiff line numberDiff line change
@@ -4361,12 +4361,6 @@ cc_library(
43614361
name = "simdutf",
43624362
srcs = ["third_party/simdutf/simdutf.cpp"],
43634363
hdrs = ["third_party/simdutf/simdutf.h"],
4364-
copts = select({
4365-
"@v8//bazel/config:is_clang": ["-std=c++20"],
4366-
"@v8//bazel/config:is_gcc": ["-std=gnu++2a"],
4367-
"@v8//bazel/config:is_windows": ["/std:c++20"],
4368-
"//conditions:default": [],
4369-
}),
43704364
)
43714365

43724366
v8_library(

deps/v8/src/builtins/builtins-typed-array.cc

+5-10
Original file line numberDiff line numberDiff line change
@@ -818,16 +818,11 @@ BUILTIN(Uint8ArrayPrototypeToBase64) {
818818
// is false.
819819
// 11. Return CodePointsToString(outAscii).
820820

821-
size_t simd_result_size;
822-
if (uint8array->buffer()->is_shared()) {
823-
simd_result_size = simdutf::atomic_binary_to_base64(
824-
std::bit_cast<const char*>(uint8array->GetBuffer()->backing_store()),
825-
length, reinterpret_cast<char*>(output->GetChars(no_gc)), alphabet);
826-
} else {
827-
simd_result_size = simdutf::binary_to_base64(
828-
std::bit_cast<const char*>(uint8array->GetBuffer()->backing_store()),
829-
length, reinterpret_cast<char*>(output->GetChars(no_gc)), alphabet);
830-
}
821+
// TODO(rezvan): Make sure to add a path for SharedArrayBuffers when
822+
// simdutf library got updated. Also, add a test for it.
823+
size_t simd_result_size = simdutf::binary_to_base64(
824+
std::bit_cast<const char*>(uint8array->GetBuffer()->backing_store()),
825+
length, reinterpret_cast<char*>(output->GetChars(no_gc)), alphabet);
831826
DCHECK_EQ(simd_result_size, output_length);
832827
USE(simd_result_size);
833828
}

deps/v8/test/mjsunit/harmony/uint8-array-to-base64-on-shared-array-buffer.js

-56
This file was deleted.

0 commit comments

Comments
 (0)