Skip to content

Commit 25973fd

Browse files
committed
ci: improve golangci-lint output
After the patch golangci-lint prints a file and a line number [1]. 1. golangci/golangci-lint-action#119 Closes #231
1 parent a1f28a6 commit 25973fd

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

.github/workflows/check.yaml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ jobs:
3737
- uses: actions/checkout@v2
3838

3939
- name: golangci-lint
40-
uses: golangci/golangci-lint-action@v2
40+
uses: golangci/golangci-lint-action@v3
41+
continue-on-error: true
4142
with:
4243
# The suppression of the rule `errcheck` may be removed after adding
4344
# errors check in all methods calling EncodeXxx inside.
@@ -47,8 +48,17 @@ jobs:
4748
# The `//nolint` workaround was not the acceptable way of warnings suppression,
4849
# cause those comments get rendered in documentation by godoc.
4950
# See https://github.com/tarantool/go-tarantool/pull/160#discussion_r858608221
51+
#
52+
# The first run is for GitHub Actions error format.
5053
args: -E goimports -D errcheck
5154

55+
- name: golangci-lint
56+
uses: golangci/golangci-lint-action@v3
57+
with:
58+
# The second run is for human-readable error format with a file name
59+
# and a line number.
60+
args: --out-${NO_FUTURE}format colored-line-number -E goimports -D errcheck
61+
5262
codespell:
5363
runs-on: ubuntu-latest
5464
if: |

connector.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ type Connector interface {
1111
Select(space, index interface{}, offset, limit, iterator uint32, key interface{}) (resp *Response, err error)
1212
Insert(space interface{}, tuple interface{}) (resp *Response, err error)
1313
Replace(space interface{}, tuple interface{}) (resp *Response, err error)
14-
Delete(space, index interface{}, key interface{}) (resp *Response, err error)
14+
Delete(space, index interface{}, key interface{}) (resp *Response, err error)
1515
Update(space, index interface{}, key, ops interface{}) (resp *Response, err error)
1616
Upsert(space interface{}, tuple, ops interface{}) (resp *Response, err error)
1717
Call(functionName string, args interface{}) (resp *Response, err error)

0 commit comments

Comments
 (0)