Skip to content

Commit f223132

Browse files
committed
ensure we only allow "left click"
A normal `click` handles that for you, but a mousedown does not. Let's only allow a normal left click only.
1 parent 073e35b commit f223132

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

packages/@headlessui-react/src/components/listbox/listbox.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -394,6 +394,7 @@ function ButtonFn<TTag extends ElementType = typeof DEFAULT_BUTTON_TAG>(
394394
})
395395

396396
let handleMouseDown = useEvent((event: ReactMouseEvent) => {
397+
if (event.button !== 0) return // Only handle left clicks
397398
if (isDisabledReactIssue7711(event.currentTarget)) return event.preventDefault()
398399
if (machine.state.listboxState === ListboxStates.Open) {
399400
flushSync(() => machine.actions.closeListbox())

packages/@headlessui-react/src/components/menu/menu.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,7 @@ function ButtonFn<TTag extends ElementType = typeof DEFAULT_BUTTON_TAG>(
230230
])
231231

232232
let handleMouseDown = useEvent((event: ReactMouseEvent) => {
233+
if (event.button !== 0) return // Only handle left clicks
233234
if (isDisabledReactIssue7711(event.currentTarget)) return event.preventDefault()
234235
if (disabled) return
235236
if (menuState === MenuState.Open) {

0 commit comments

Comments
 (0)