use simpler version

RobinMalfait · RobinMalfait · commit ddef5c76f91f · 2024-09-27T11:34:40.000+02:00
diff --git a/packages/@headlessui-react/src/internal/floating.tsx b/packages/@headlessui-react/src/internal/floating.tsx
@@ -134,10 +134,12 @@ export function useFloatingPanel(
     () => placement,
     [
       JSON.stringify(placement, (_, v) => {
-        if (typeof v === 'object' && v !== null && 'outerHTML' in v) {
-          return v.outerHTML
-        }
-        return v
+        // When we are trying to stringify a DOM element, we want to return the
+        // `outerHTML` of the element. In all other cases, we want to return the
+        // value as-is.
+        // It's not safe enough to check whether `v` is an instanceof
+        // `HTMLElement` because some tools (like AG Grid) polyfill it to be `{}`.
+        return v?.outerHTML ?? v
       }),
     ]
   )

Original file line number	Diff line number	Diff line change
`@@ -134,10 +134,12 @@ export function useFloatingPanel(`
`134`	`134`	`() => placement,`
`135`	`135`	`[`
`136`	`136`	`JSON.stringify(placement, (_, v) => {`
`137`		`- if (typeof v === 'object' && v !== null && 'outerHTML' in v) {`
`138`		`- return v.outerHTML`
`139`		`- }`
`140`		`- return v`
	`137`	`+ // When we are trying to stringify a DOM element, we want to return the`
	`138`	+ // `outerHTML` of the element. In all other cases, we want to return the
	`139`	`+ // value as-is.`
	`140`	+ // It's not safe enough to check whether `v` is an instanceof
	`141`	+ // `HTMLElement` because some tools (like AG Grid) polyfill it to be `{}`.
	`142`	`+ return v?.outerHTML ?? v`
`141`	`143`	`}),`
`142`	`144`	`]`
`143`	`145`	`)`