SteamOS Update Resilience #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legowerewolf
approved these changes
Dec 15, 2023
|
Alright, I've applied |
|
I'd be okay merging this, even if we haven't tested it with a real update. I can't see it worsening the current experience or malfunctioning, and it stands a good chance at surviving future updates. I'll report back when I receive a SteamOS update with my anecdotes. I suggest we keep #13 open until then |
|
Whatever ya'll are cool with! I'll mark it as ready in the meantime. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would love to see these changes persist through a SteamOS update. Here are some changes I think will work, but have not been thoroughly tested yet through an actual update.
From my understanding the only reason this solution breaks on an os update is
systemd-sysextis comparingextension-release.tailscaledagainst/etc/os-releaseand the versions are not matching.The idea here is that we stop checking against our system version when mounting the system extension. From the docs:
So I believe if we set
IDto_anyit will not continue comparing against/etc/os-release. I'm not sure where theSYSEXT_LEVELvalue is coming from though...I think we should wait until someone can really test this though.