Skip to content

feat(taiko-client): remove DELETE /preconfBlocks API #19537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2025

Conversation

davidtaikocha
Copy link
Contributor

No description provided.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the DELETE /preconfBlocks endpoint and all related types, handlers, tests, and chain-sync logic.

  • Drops RemovePreconfBlocks from the syncer interface, server routes, handler definitions, and chain-inserter
  • Deletes all API request/response types and handler code for the DELETE route
  • Cleans up associated tests in driver_test.go

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/taiko-client/driver/preconf_blocks/server.go Removed RemovePreconfBlocks interface method and route
packages/taiko-client/driver/preconf_blocks/api.go Deleted handler, types, and import for DELETE endpoint
packages/taiko-client/driver/driver_test.go Removed tests targeting the DELETE endpoint
packages/taiko-client/driver/chain_syncer/event/blocks_inserter/pacaya.go Removed RemovePreconfBlocks method from inserter
Comments suppressed due to low confidence (3)

packages/taiko-client/driver/preconf_blocks/api.go:9

  • The reference to ethereum.NotFound in BuildPreconfBlock is no longer resolved since the import of github.com/ethereum/go-ethereum was removed. Reintroduce the correct package import or update the error check to use an available error constant.
-	"github.com/ethereum/go-ethereum"

packages/taiko-client/driver/preconf_blocks/api.go:269

  • Ensure any OpenAPI/Swagger specification or external documentation is updated to remove the DELETE /preconfBlocks operation so docs remain in sync with code.
-// RemovePreconfBlocksRequestBody represents a request body when resetting the backend

packages/taiko-client/driver/driver_test.go:429

  • After removing all references to RemovePreconfBlocksRequestBody, verify and remove any unused imports (e.g., the preconfblocks package) to avoid compilation errors in tests.
-	// Remove one preconfirmation block

Copy link

codecov bot commented May 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.54%. Comparing base (4a22f7a) to head (7b9c302).
Report is 1 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
...river/chain_syncer/event/blocks_inserter/pacaya.go 0.00% <ø> (ø)
packages/taiko-client/driver/preconf_blocks/api.go 0.00% <ø> (ø)
...kages/taiko-client/driver/preconf_blocks/server.go 9.87% <ø> (-0.12%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a22f7a...7b9c302. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davidtaikocha davidtaikocha added this pull request to the merge queue May 26, 2025
Merged via the queue into main with commit 9678be5 May 26, 2025
9 checks passed
@davidtaikocha davidtaikocha deleted the remove-remove-preconf-block-api branch May 26, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants