-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(taiko-client): remove DELETE /preconfBlocks
API
#19537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the DELETE /preconfBlocks
endpoint and all related types, handlers, tests, and chain-sync logic.
- Drops
RemovePreconfBlocks
from the syncer interface, server routes, handler definitions, and chain-inserter - Deletes all API request/response types and handler code for the DELETE route
- Cleans up associated tests in
driver_test.go
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/taiko-client/driver/preconf_blocks/server.go | Removed RemovePreconfBlocks interface method and route |
packages/taiko-client/driver/preconf_blocks/api.go | Deleted handler, types, and import for DELETE endpoint |
packages/taiko-client/driver/driver_test.go | Removed tests targeting the DELETE endpoint |
packages/taiko-client/driver/chain_syncer/event/blocks_inserter/pacaya.go | Removed RemovePreconfBlocks method from inserter |
Comments suppressed due to low confidence (3)
packages/taiko-client/driver/preconf_blocks/api.go:9
- The reference to
ethereum.NotFound
inBuildPreconfBlock
is no longer resolved since the import ofg.yxqyang.asia/ethereum/go-ethereum
was removed. Reintroduce the correct package import or update the error check to use an available error constant.
- "github.com/ethereum/go-ethereum"
packages/taiko-client/driver/preconf_blocks/api.go:269
- Ensure any OpenAPI/Swagger specification or external documentation is updated to remove the
DELETE /preconfBlocks
operation so docs remain in sync with code.
-// RemovePreconfBlocksRequestBody represents a request body when resetting the backend
packages/taiko-client/driver/driver_test.go:429
- After removing all references to
RemovePreconfBlocksRequestBody
, verify and remove any unused imports (e.g., thepreconfblocks
package) to avoid compilation errors in tests.
- // Remove one preconfirmation block
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
No description provided.