Skip to content

fix(taiko-client): curr range lookahead fix #19529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 24, 2025
Merged

fix(taiko-client): curr range lookahead fix #19529

merged 7 commits into from
May 24, 2025

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented May 24, 2025

current lookahead incorrectly returns current range of the current epoch for regardless of operator, this fixes it. Not a big issue because preconf sidecars also keep track of this, but should be fixed.

@cyberhorsey cyberhorsey changed the title fix(taiko-client): lookahead fi fix(taiko-client): lookahead fix May 24, 2025
@cyberhorsey cyberhorsey self-assigned this May 24, 2025
@cyberhorsey cyberhorsey changed the title fix(taiko-client): lookahead fix fix(taiko-client): curr range lookahead fix May 24, 2025
Copy link

codecov bot commented May 24, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 26.40%. Comparing base (e30687c) to head (cb05c91).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/taiko-client/driver/driver.go 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...es/taiko-client/driver/preconf_blocks/lookahead.go 100.00% <100.00%> (ø)
packages/taiko-client/driver/driver.go 15.29% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e30687c...cb05c91. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cyberhorsey cyberhorsey enabled auto-merge May 24, 2025 04:52
@davidtaikocha davidtaikocha requested a review from Copilot May 24, 2025 05:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the lookahead logic so that the current range is correctly determined based solely on the current operator, rather than including the next operator as well. Key changes include:

  • Modifying the SequencingWindowSplit logic to only consider currOps in lookahead.go.
  • Updating unit tests in lookahead_test.go to reflect the new logic and adding extra test cases for alternative operator handling.
  • Adding a clarifying comment in driver.go regarding operation pushing.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
packages/taiko-client/driver/preconf_blocks/lookahead_test.go Updated test expectations and messages to validate revised lookahead splits.
packages/taiko-client/driver/preconf_blocks/lookahead.go Revised logic to only check the current operator for lookahead range.
packages/taiko-client/driver/driver.go Minor comment update to clarify operator pushing behavior.

@cyberhorsey cyberhorsey added this pull request to the merge queue May 24, 2025
Merged via the queue into main with commit 38f7ad4 May 24, 2025
9 checks passed
@cyberhorsey cyberhorsey deleted the lookahead_fix_2 branch May 24, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants