-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix(taiko-client): curr range lookahead fix #19529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the lookahead logic so that the current range is correctly determined based solely on the current operator, rather than including the next operator as well. Key changes include:
- Modifying the SequencingWindowSplit logic to only consider currOps in lookahead.go.
- Updating unit tests in lookahead_test.go to reflect the new logic and adding extra test cases for alternative operator handling.
- Adding a clarifying comment in driver.go regarding operation pushing.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
packages/taiko-client/driver/preconf_blocks/lookahead_test.go | Updated test expectations and messages to validate revised lookahead splits. |
packages/taiko-client/driver/preconf_blocks/lookahead.go | Revised logic to only check the current operator for lookahead range. |
packages/taiko-client/driver/driver.go | Minor comment update to clarify operator pushing behavior. |
current lookahead incorrectly returns current range of the current epoch for regardless of operator, this fixes it. Not a big issue because preconf sidecars also keep track of this, but should be fixed.