-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(taiko-client): check router on taiko wrapper before allowing preconf block to be made #19525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Changed to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a router check in the preconfirmation block creation process to ensure that preconfirmation submissions are allowed only when the router is enabled.
- Added a simple router check in the BuildPreconfBlock method.
- Introduced new imports and error handling logic in the API.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
packages/taiko-client/driver/preconf_blocks/server.go | Added a newline that improves code readability. |
packages/taiko-client/driver/preconf_blocks/api.go | Implemented a router check before preconfirmation block creation. |
Comments suppressed due to low confidence (1)
packages/taiko-client/driver/preconf_blocks/api.go:75
- [nitpick] Enhance the error message to include additional context or guidance on how to resolve the issue when preconfirmation is disabled by the taikoWrapper.
if preconfRouter == rpc.ZeroAddress {
Will block preconfs from being submitted if we disable the router, barring a sequencer issue of failing to detect this and tryign to preconf blocks.