Skip to content

feat(taiko-client): check router on taiko wrapper before allowing preconf block to be made #19525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 24, 2025

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented May 23, 2025

Will block preconfs from being submitted if we disable the router, barring a sequencer issue of failing to detect this and tryign to preconf blocks.

Copy link

codecov bot commented May 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.

Project coverage is 26.48%. Comparing base (b599ffe) to head (4b8cafb).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/taiko-client/driver/preconf_blocks/api.go 0.00% 41 Missing ⚠️
...river/chain_syncer/event/blocks_inserter/pacaya.go 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...kages/taiko-client/driver/preconf_blocks/server.go 9.98% <ø> (ø)
...river/chain_syncer/event/blocks_inserter/pacaya.go 0.00% <0.00%> (ø)
packages/taiko-client/driver/preconf_blocks/api.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b599ffe...4b8cafb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davidtaikocha davidtaikocha enabled auto-merge May 24, 2025 00:47
@davidtaikocha
Copy link
Contributor

Changed to use s.rpc.GetPreconfRouterPacaya (which includes RPC timeout), and approved.

@davidtaikocha davidtaikocha requested a review from Copilot May 24, 2025 00:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a router check in the preconfirmation block creation process to ensure that preconfirmation submissions are allowed only when the router is enabled.

  • Added a simple router check in the BuildPreconfBlock method.
  • Introduced new imports and error handling logic in the API.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/taiko-client/driver/preconf_blocks/server.go Added a newline that improves code readability.
packages/taiko-client/driver/preconf_blocks/api.go Implemented a router check before preconfirmation block creation.
Comments suppressed due to low confidence (1)

packages/taiko-client/driver/preconf_blocks/api.go:75

  • [nitpick] Enhance the error message to include additional context or guidance on how to resolve the issue when preconfirmation is disabled by the taikoWrapper.
if preconfRouter == rpc.ZeroAddress {

@davidtaikocha davidtaikocha added this pull request to the merge queue May 24, 2025
Merged via the queue into main with commit 0c4bd86 May 24, 2025
9 checks passed
@davidtaikocha davidtaikocha deleted the check_taiko_wrapper_preconf_router branch May 24, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants