Skip to content

feat(taiko-client): introduce --prover.localProposerAddresses flag #19517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2025

Conversation

davidtaikocha
Copy link
Contributor

ref: #18765

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new CLI flag (--prover.localProposerAddresses) that allows the prover to accept batches from a set of locally configured proposer addresses. Key changes include:

  • Updating the Prover configuration and its initialization to include local proposer addresses.
  • Modifying event handler logic and logging to consider the new local proposer addresses when deciding if a batch is provable.
  • Adding CLI flag parsing and validation for the new configuration field.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/taiko-client/prover/init.go Adds LocalProposerAddresses to the event handler configuration
packages/taiko-client/prover/event_handler/batch_proposed.go Updates expiration condition logic and logging to account for local proposer addresses
packages/taiko-client/prover/config.go Extends configuration structure and CLI parsing for local proposer addresses
packages/taiko-client/cmd/flags/prover.go Introduces the new CLI flag with proper usage and environment variable settings
Comments suppressed due to low confidence (1)

packages/taiko-client/prover/event_handler/batch_proposed.go:203

  • Verify that removing the explicit check against h.proverAddress in the expiration condition is intentional, now that local proposer addresses are considered.
meta.GetProposer() != h.proverSetAddress &&

@davidtaikocha davidtaikocha enabled auto-merge May 23, 2025 01:58
@davidtaikocha davidtaikocha added this pull request to the merge queue May 23, 2025
Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 20.37037% with 43 lines in your changes missing coverage. Please review.

Project coverage is 26.57%. Comparing base (3fc156e) to head (109b469).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/taiko-client/prover/config.go 0.00% 30 Missing ⚠️
...aiko-client/prover/event_handler/batch_proposed.go 7.14% 13 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
packages/taiko-client/prover/init.go 61.99% <100.00%> (+0.14%) ⬆️
...aiko-client/prover/event_handler/batch_proposed.go 33.50% <7.14%> (-1.50%) ⬇️
packages/taiko-client/prover/config.go 12.30% <0.00%> (-1.73%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc156e...109b469. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into main with commit e7b8f05 May 23, 2025
9 checks passed
@davidtaikocha davidtaikocha deleted the add-local-addrs-provers branch May 23, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants