-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(taiko-client): introduce --prover.localProposerAddresses
flag
#19517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new CLI flag (--prover.localProposerAddresses) that allows the prover to accept batches from a set of locally configured proposer addresses. Key changes include:
- Updating the Prover configuration and its initialization to include local proposer addresses.
- Modifying event handler logic and logging to consider the new local proposer addresses when deciding if a batch is provable.
- Adding CLI flag parsing and validation for the new configuration field.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
packages/taiko-client/prover/init.go | Adds LocalProposerAddresses to the event handler configuration |
packages/taiko-client/prover/event_handler/batch_proposed.go | Updates expiration condition logic and logging to account for local proposer addresses |
packages/taiko-client/prover/config.go | Extends configuration structure and CLI parsing for local proposer addresses |
packages/taiko-client/cmd/flags/prover.go | Introduces the new CLI flag with proper usage and environment variable settings |
Comments suppressed due to low confidence (1)
packages/taiko-client/prover/event_handler/batch_proposed.go:203
- Verify that removing the explicit check against h.proverAddress in the expiration condition is intentional, now that local proposer addresses are considered.
meta.GetProposer() != h.proverSetAddress &&
Co-authored-by: Copilot <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ref: #18765