Skip to content

feat(taiko-client): improve isBatchPreconfirmed #19373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025

Conversation

davidtaikocha
Copy link
Contributor

No description provided.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the implementation of isBatchPreconfirmed by parallelizing the per-block preconfirmation checks.

  • Introduces parallel execution using an error group for each block in the batch.
  • Adjusts header retrieval and updates to use a newly obtained parent header in place of the original parent.

Copy link

codecov bot commented May 1, 2025

Codecov Report

Attention: Patch coverage is 86.04651% with 6 lines in your changes missing coverage. Please review.

Project coverage is 38.63%. Comparing base (1dce498) to head (fa3abac).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...river/chain_syncer/event/blocks_inserter/common.go 86.04% 4 Missing and 2 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...river/chain_syncer/event/blocks_inserter/common.go 65.60% <86.04%> (+0.84%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dce498...fa3abac. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davidtaikocha davidtaikocha added this pull request to the merge queue May 2, 2025
Merged via the queue into main with commit efe2d99 May 2, 2025
9 checks passed
@davidtaikocha davidtaikocha deleted the improve-isBatchPreconfirmed branch May 2, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants