-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore(taiko-client): add more preconfirmation metrics #19342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds new metrics for preconfirmation events in the taiko-client to enhance monitoring of P2P envelope handling.
- Introduces three new counters in the metrics package for tracking invalid, outdated, and cached envelopes.
- Updates the preconfirmation server to increment the new metrics based on envelope validation and caching events.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/taiko-client/internal/metrics/metrics.go | Adds three new counter metrics for tracking preconfirmation envelope statuses |
packages/taiko-client/driver/preconf_blocks/server.go | Integrates metric counter increments at key points during envelope processing |
Comments suppressed due to low confidence (3)
packages/taiko-client/driver/preconf_blocks/server.go:194
- Consider adding unit tests to verify that the metric counter for invalid envelopes is incremented as expected when an invalid envelope is encountered.
metrics.DriverPreconfP2PInvalidEnvelopeCounter.Inc()
packages/taiko-client/driver/preconf_blocks/server.go:204
- Consider adding unit tests to confirm that the outdated envelope counter increments correctly when the block number is less than or equal to the current head L1 origin block ID.
metrics.DriverPreconfP2POutdatedEnvelopeCounter.Inc()
packages/taiko-client/driver/preconf_blocks/server.go:253
- Consider adding unit tests to ensure that the envelope cached counter is properly incremented when an envelope is added to the payloads cache.
metrics.DriverPreconfP2PEnvelopeCachedCounter.Inc()
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
No description provided.