feat(taiko-client): introduce ImportPendingBlocksFromCache in PreconfBlockAPIServer
#19339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfBlockAPIServer`
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new method, ImportPendingBlocksFromCache, in the PreconfBlockAPIServer to recover pending preconfirmation blocks from the cache and integrates it with the L2ChainSyncer.
- Implements ImportPendingBlocksFromCache in server.go
- Propagates the latest payload from queue.go
- Updates driver.go and chain_syncer.go to wire the new functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/taiko-client/driver/preconf_blocks/server.go | Adds the ImportPendingBlocksFromCache method to retrieve pending blocks |
| packages/taiko-client/driver/preconf_blocks/queue.go | Updates the payloadQueue structure to store the latest payload |
| packages/taiko-client/driver/driver.go | Sets the preconfirmation block server in the driver configuration |
| packages/taiko-client/driver/chain_syncer/chain_syncer.go | Triggers population of pending preconfirmation blocks during chain synchronization |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces functionality to import pending preconfirmation blocks from the cache into the preconfirmation block server and properly wires it into the chain synchronization process.
- Introduces the ImportPendingBlocksFromCache method in PreconfBlockAPIServer.
- Adds a helper method getLatestPayload in the payloadQueue.
- Connects the preconfirmation block server within the driver and chain syncer for proper integration.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/taiko-client/driver/preconf_blocks/server.go | Adds ImportPendingBlocksFromCache, with a minor spelling issue in variable naming. |
| packages/taiko-client/driver/preconf_blocks/queue.go | Introduces the getLatestPayload helper to retrieve the latest payload from the queue. |
| packages/taiko-client/driver/driver.go | Sets the preconfirmation block server in the driver. |
| packages/taiko-client/driver/chain_syncer/chain_syncer.go | Integrates the preconfirmation block server for block recovery on chain sync. |
Co-authored-by: Copilot <[email protected]>
cyberhorsey
approved these changes
Apr 27, 2025
YoGhurt111
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR, when a newly started L2 EE chain has finished a beacon sync,
driverwill try to import pending P2P preconf blocks in the cache.