Skip to content

feat(miner): use []*ethapi.RPCTransaction in RPC response body #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

davidtaikocha
Copy link

@davidtaikocha davidtaikocha commented Feb 24, 2025

As suggested by Maciej:

One more concern: wouldn't it be more universal to return RPCTransaction in the taikoAuth_txPoolContentWithMinTip instead Transaction? The difference is that RCPTransaction include directly from field. I noticed that while parsing json using Rust Alloy library, which expects this field to be present by default (It can be parsed though with some simple workarounds, recovering from from signature).

@davidtaikocha davidtaikocha merged commit afd09af into taiko Feb 24, 2025
3 checks passed
@davidtaikocha davidtaikocha deleted the use-rpc-txs branch February 24, 2025 08:41
davidtaikocha added a commit that referenced this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants