You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
bug #515 Fix constants being redefined in PHP 8.4 polyfill (cs278)
This PR was squashed before being merged into the 1.x branch.
Discussion
----------
Fix constants being redefined in PHP 8.4 polyfill
Tracked down this error to this library:
```
In bootstrap.php line 19:
[ErrorException]
Constant CURL_HTTP_VERSION_3 already defined
```
It appears to me the standard is to conditionally define symbols so these two were missing a check. I've also added a basic test which should prevent this happening again.
Commits
-------
230379b Fix constants being redefined in PHP 8.4 polyfill
if (defined('CURLOPT_SSH_HOST_PUBLIC_KEY_SHA256')) { // libcurl >= 7.80.0 (7.88 would be better but is slow to check)
23
+
if (!defined('CURL_HTTP_VERSION_3ONLY') && defined('CURLOPT_SSH_HOST_PUBLIC_KEY_SHA256')) { // libcurl >= 7.80.0 (7.88 would be better but is slow to check)
0 commit comments