Install and run some Go linters

Author: zimmski

.github/workflows/ci.yml

@@ -14,6 +14,9 @@ jobs:
   docker:
     name: 'Run docker image building'
     uses: ./.github/workflows/docker.yml
+  lint:
+    name: 'Lint all the things!'
+    uses: ./.github/workflows/lint.yml
   test:
     name: 'Run tests and linting'
     strategy:

.github/workflows/lint.yml

@@ -0,0 +1,26 @@
+on:
+  workflow_call:
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: '1.21'
+
+      - name: Install ack
+        run: sudo apt-get update && sudo apt-get install -y ack-grep
+        shell: bash # Explicitly use Bash because otherwise failing Windows jobs are not erroring.
+
+      - name: Install testing linting
+        run: make install-tools-linting
+        shell: bash # Explicitly use Bash because otherwise failing Windows jobs are not erroring.
+
+      - name: Lint
+        run: make lint
+        shell: bash # Explicitly use Bash because otherwise failing Windows jobs are not erroring.

Makefile

@@ -47,13 +47,19 @@ install: # [Go package] - # Build and install everything, or only the specified
 	go install -v -ldflags="$(GO_LDFLAGS)" $(PACKAGE)
 .PHONY: install
 
-install-all: install install-tools install-tools-testing # Install everything for and of this repository.
+install-all: install install-tools install-tools-linting install-tools-testing # Install everything for and of this repository.
 .PHONY: install-all
 
 install-tools: # Install tools that are required for running the evaluation.
 	eval-dev-quality install-tools $(if $(ARGS), --install-tools-path $(word 1,$(ARGS)))
 .PHONY: install-tools
 
+install-tools-linting: # Install tools that are used for linting.
+	go install -v github.com/kisielk/[email protected]
+	go install -v github.com/mgechev/[email protected]
+	go install -v honnef.co/go/tools/cmd/[email protected]
+.PHONY: install-tools-linting
+
 install-tools-testing: # Install tools that are used for testing.
 	go install -v github.com/vektra/mockery/[email protected]
 	go install -v gotest.tools/[email protected]
@@ -63,6 +69,13 @@ generate: # Run code generation.
 	mockery
 .PHONY: generate
 
+lint: # Check repository.
+	errcheck ./...
+	go vet ./...
+	revive ./... | ack -v "(should have a package comment|seems to be unused, consider removing or renaming it)" || true
+	staticcheck ./...
+.PHONY: lint
+
 lint-build-ci: generate # Check artifacts.
 	make require-clean-worktree
 .PHONY: lint-build-ci