Add tests [17] --filter=[core] --asan

Author: matyhtf

core-tests/src/coroutine/hook.cpp

@@ -242,13 +242,14 @@ TEST(coroutine_hook, rename) {
 }
 
 TEST(coroutine_hook, flock) {
-    if (is_github_ci()) {
-        return;
-    }
     long start_time = swoole::time<std::chrono::milliseconds>();
     coroutine::run([&](void *arg) {
-        swoole::Coroutine::create([&](void *arg) {
+        Coroutine::create([&](void *arg) {
             int fd = swoole_coroutine_open(TEST_TMP_FILE, O_WRONLY, 0);
+
+            ASSERT_EQ(swoole_coroutine_flock(fd, 16), SW_ERR);
+            ASSERT_ERREQ(EINVAL);
+
             ASSERT_EQ(swoole_coroutine_flock(fd, LOCK_EX), 0);
             System::sleep(0.1);
             ASSERT_EQ(swoole_coroutine_flock(fd, LOCK_UN), 0);
@@ -258,10 +259,10 @@ TEST(coroutine_hook, flock) {
             ASSERT_LE(swoole::time<std::chrono::milliseconds>() - start_time, 1000);
             swoole_coroutine_close(fd);
         });
-        swoole::Coroutine::create([&](void *arg) {
+        Coroutine::create([&](void *arg) {
             int fd = swoole_coroutine_open(TEST_TMP_FILE, O_WRONLY, 0);
             ASSERT_EQ(swoole_coroutine_flock(fd, LOCK_SH), 0);
-            System::sleep(2);
+            System::sleep(0.5);
             ASSERT_EQ(swoole_coroutine_flock(fd, LOCK_UN), 0);
             swoole_coroutine_close(fd);
         });

core-tests/src/coroutine/system.cpp

@@ -369,3 +369,17 @@ TEST(coroutine_system, waitpid) {
         kill(pid, SIGKILL);
     });
 }
+
+TEST(coroutine_system, read_file_fail) {
+    test::coroutine::run([](void *arg) {
+        ASSERT_EQ(System::read_file("/tmp/not-exists", true), nullptr);
+        ASSERT_EQ(errno, ENOENT);
+    });
+}
+
+TEST(coroutine_system, write_file_fail) {
+    test::coroutine::run([](void *arg) {
+        ASSERT_EQ(System::write_file("/tmp/not-exists/file.log", SW_STRL(TEST_STR)), -1);
+        ASSERT_EQ(errno, ENOENT);
+    });
+}

core-tests/src/server/server.cpp

@@ -1196,7 +1196,7 @@ TEST(server, task_worker) {
     ASSERT_EQ(serv.gs->task_count, 2);
 }
 
-static void test_task(Server::Mode mode,  uint8_t task_ipc_mode = Server::TASK_IPC_UNIXSOCK) {
+static void test_task(Server::Mode mode, uint8_t task_ipc_mode = Server::TASK_IPC_UNIXSOCK) {
     Server serv(mode);
     serv.worker_num = 2;
     serv.task_ipc_mode = task_ipc_mode;

include/swoole_coroutine_system.h

@@ -49,7 +49,7 @@ class System {
     static int sleep(double sec);
     /* file */
     static std::shared_ptr<String> read_file(const char *file, bool lock = false);
-    static ssize_t write_file(const char *file, char *buf, size_t length, bool lock = 0, int flags = 0);
+    static ssize_t write_file(const char *file, const char *buf, size_t length, bool lock = 0, int flags = 0);
     /* dns */
     static std::string gethostbyname(const std::string &hostname, int domain, double timeout = -1);
     static std::vector<std::string> getaddrinfo(const std::string &hostname,

src/coroutine/system.cc

@@ -135,7 +135,7 @@ std::shared_ptr<String> System::read_file(const char *file, bool lock) {
     return result;
 }
 
-ssize_t System::write_file(const char *file, char *buf, size_t length, bool lock, int flags) {
+ssize_t System::write_file(const char *file, const char *buf, size_t length, bool lock, int flags) {
     ssize_t retval = -1;
     int file_flags = flags | O_CREAT | O_WRONLY;
     async([&]() {