You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As already discussed in the context of #9 and #31:
[...] Please consider using a package namespace that you have sole control over, as org.gnome.* and org.freedesktop.* etc will lead to split packages in the post-Java-8 modular world.
Convention would be for Maven group/artifact, Java module name and root package name to match.
I would suggest to move those packages to de.swiesend.secretservice.gnome.* and de.swiesend.secretservice.freedesktop.* respectively.
Since this is a breaking change, it should be considered before releasing 2.0.0.
Together with #37 and #31 you would then be ready to add a module-info.java (I would volunteer to create a PR).
The text was updated successfully, but these errors were encountered:
I tested 2.0.0-alpha with latest Cryptomator and it works fine without issues.
For testing purposes I created two vaults, saved the passwords in the keyring with a locked and an unlocked keyring, changed the password for a vault and let Cryptomator forget it. And I dismissed the unlock keyring pop-up.
Just a minor note: waiting 2 minutes on the unlock keyring pop-up dismissed it correctly. On my Fedora 38, this crashed gnome-keyring, but as this is a daemon, it restarted and that did not harm the Cryptomator functionality in any way.
LGTM. As the package names in integrations-linux changed and just altering the Maven artifact version isn't enough, I'll create a PR for integrations-linux.
As already discussed in the context of #9 and #31:
I would suggest to move those packages to
de.swiesend.secretservice.gnome.*
andde.swiesend.secretservice.freedesktop.*
respectively.Since this is a breaking change, it should be considered before releasing 2.0.0.
Together with #37 and #31 you would then be ready to add a
module-info.java
(I would volunteer to create a PR).The text was updated successfully, but these errors were encountered: