Skip to content

avoid split packages #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
overheadhunter opened this issue Feb 15, 2023 · 2 comments
Open

avoid split packages #38

overheadhunter opened this issue Feb 15, 2023 · 2 comments

Comments

@overheadhunter
Copy link
Collaborator

As already discussed in the context of #9 and #31:

[...] Please consider using a package namespace that you have sole control over, as org.gnome.* and org.freedesktop.* etc will lead to split packages in the post-Java-8 modular world.

Convention would be for Maven group/artifact, Java module name and root package name to match.

I would suggest to move those packages to de.swiesend.secretservice.gnome.* and de.swiesend.secretservice.freedesktop.* respectively.

Since this is a breaking change, it should be considered before releasing 2.0.0.

Together with #37 and #31 you would then be ready to add a module-info.java (I would volunteer to create a PR).

@swiesend
Copy link
Owner

swiesend commented Oct 2, 2023

Should be closed by #40.

2.0.0-alpha is released.

@purejava
Copy link
Contributor

purejava commented Oct 3, 2023

I tested 2.0.0-alpha with latest Cryptomator and it works fine without issues.

For testing purposes I created two vaults, saved the passwords in the keyring with a locked and an unlocked keyring, changed the password for a vault and let Cryptomator forget it. And I dismissed the unlock keyring pop-up.

Just a minor note: waiting 2 minutes on the unlock keyring pop-up dismissed it correctly. On my Fedora 38, this crashed gnome-keyring, but as this is a daemon, it restarted and that did not harm the Cryptomator functionality in any way.

LGTM. As the package names in integrations-linux changed and just altering the Maven artifact version isn't enough, I'll create a PR for integrations-linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants