Skip to content

explain branches #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jorobledo opened this issue Oct 14, 2024 · 9 comments
Open

explain branches #1022

jorobledo opened this issue Oct 14, 2024 · 9 comments
Labels
type:discussion Discussion or feedback about the lesson

Comments

@jorobledo
Copy link

How could the content be improved?

Hi,
I read the content of the course, which I found very good! Nice job on that. But I found an omission (at least from what I could inspect) in explaining what branches are and how to use them. Is this on purpose? I think it is a very useful feature that git provides and that it should also be taught. I would be willing to develop some content for the course if there is interest.

Please let me know you opinion!

@martinosorb martinosorb added the type:discussion Discussion or feedback about the lesson label Oct 22, 2024
@martinosorb
Copy link
Contributor

Hi, thanks for this. I am personally in favour of adding branches, however this is an issue that has been debated and is currently controversial. We can keep this issue open for further discussion.

@jorobledo
Copy link
Author

I am still very much of the opinion that git users should know branching.

Would it make sense to do an initial PR to put the discussion forward and work on top of this initial version?

@martinosorb
Copy link
Contributor

@swcarpentry/git-novice-maintainers : I would be in favour of adding an 'extra' episode that could give an overview of branching, in a way that could be skipped if needed, so that the instructors can mix and match based on how much time they have and on what specific needs their audience has. Would that be possible?

@erinmgraham
Copy link
Contributor

I agree that adding an episode on branching would be very valuable. Given the interest and previous requests (issue #827, issue #918 [closed]), it makes sense to move forward with this. Toby noted there is a lesson in the incubator that might be a suitable starting point. And perhaps @davidwilby, @aragilar, and @marcodelapierre are still willing to help?

@marcodelapierre
Copy link

At this stage I don't have bandwidth to contribute to this, apologies.

@jorobledo
Copy link
Author

Then we can probably do an extra material at the moment, where we explain what branching is, and then we can decide where to put it and what to trim from the current curricula so that it fits with the expected time (as suggested in those other issues). Also this would give instructors the possibility to refer to a carpentries material in case of questions or interest about branching from the audience (has happened to me).

For me, explaining collaborating through GitHub and not branching is just not right at the moment, because they will need it to contribute to others repositories.

@davidwilby
Copy link

@erinmgraham Absolutely, I agree that the incubator lesson you link is a good starting point, I've taught this lesson a few times in order to include branching.

@davidwilby
Copy link

I'm going to get started having a go at this and will open a PR if that's alright with you folks?

@davidwilby
Copy link

I've opened a draft PR as a starting point for discussion: #1083

Just to reiterate the discussion points in case this is a better place to cover some of them:

  • Timing: I'm reluctant to contribute to the bloat of lessons, though I think this is a very important topic to include in this lesson.
  • Should pull requests also be covered in this lesson? They are already covered with a good example in the incubator lesson linked above.
  • How/should the originators of the material used from the incubator lesson be credited here?
  • This branching episode uses examples of a python and a bash version of an analysis as its branches - would it be preferable to use something more aligned with the food/recipe themes instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:discussion Discussion or feedback about the lesson
Projects
None yet
Development

No branches or pull requests

5 participants