fix(register): resolve internal cjs module (#811)

Author: Brooooooklyn

packages/core/index.d.ts

@@ -0,0 +1,24 @@
+import { Options as SwcOptions, ReactConfig, Config, JscTarget } from '@swc/core'
+export interface Options {
+  target?: JscTarget
+  module?: 'commonjs' | 'umd' | 'amd' | 'es6'
+  sourcemap?: Config['sourceMaps']
+  jsx?: boolean
+  experimentalDecorators?: boolean
+  emitDecoratorMetadata?: boolean
+  useDefineForClassFields?: boolean
+  dynamicImport?: boolean
+  esModuleInterop?: boolean
+  keepClassNames?: boolean
+  externalHelpers?: boolean
+  react?: Partial<ReactConfig>
+  baseUrl?: string
+  paths?: {
+    [from: string]: [string]
+  }
+  swc?: SwcOptions
+  ignoreDynamic?: boolean
+}
+export declare function transformSync(source: string, path: string, options?: Options): import('@swc/types').Output
+export declare function transformJest(source: string, path: string, options?: Options): import('@swc/types').Output
+export declare function transform(source: string, path: string, options?: Options): Promise<import('@swc/types').Output>

packages/core/index.js

@@ -0,0 +1,5 @@
+declare const exports: {
+  default: () => string
+}
+
+export default exports

packages/core/index.js.map

@@ -0,0 +1,33 @@
+// this undesirable output was commonly generated by babel w browser-breaking
+// defineProperty and default.default definitions
+
+/* eslint-disable */
+'use strict'
+
+Object.defineProperty(exports, '__esModule', {
+  value: true,
+})
+exports['default'] = void 0
+
+function _typeof(obj) {
+  '@babel/helpers - typeof'
+  if (typeof Symbol === 'function' && typeof Symbol.iterator === 'symbol') {
+    _typeof = function _typeof(obj) {
+      return typeof obj
+    }
+  } else {
+    _typeof = function _typeof(obj) {
+      return obj && typeof Symbol === 'function' && obj.constructor === Symbol && obj !== Symbol.prototype
+        ? 'symbol'
+        : typeof obj
+    }
+  }
+  return _typeof(obj)
+}
+
+var _default = function _default() {
+  return 'default.default'
+}
+
+exports['default'] = _default
+/* eslint-enable */

packages/integrate-module/src/cjs/index.d.ts

@@ -0,0 +1,5 @@
+{
+  "description": "problematic cjs file type generated by babel",
+  "main": "./index.js",
+  "types": "./index.d.ts"
+}

packages/integrate-module/src/cjs/index.js

@@ -9,6 +9,7 @@ import { renderToString } from 'react-dom/server'
 import { simpleGit } from 'simple-git'
 
 import { CompiledClass } from './compiled.js'
+import cjs from './cjs'
 import { foo } from './foo.mjs'
 import { bar } from './subdirectory/bar.mjs'
 import { baz } from './subdirectory/index.mjs'
@@ -57,3 +58,7 @@ await test('resolve @napi-rs projects', () => {
 await test('resolve simple-git', () => {
   assert.ok(simpleGit)
 })
+
+await test('resolve local cjs module', () => {
+  assert.equal(cjs.default(), 'default.default')
+})

packages/integrate-module/src/cjs/package.json

@@ -1,5 +1,12 @@
 import { readFile } from 'fs/promises'
-import { createRequire, type LoadFnOutput, type LoadHook, type ResolveFnOutput, type ResolveHook } from 'node:module'
+import {
+  createRequire,
+  type LoadFnOutput,
+  type LoadHook,
+  type ResolveFnOutput,
+  type ResolveHook,
+  builtinModules,
+} from 'node:module'
 import { extname, join } from 'path'
 import { fileURLToPath, parse as parseUrl, pathToFileURL } from 'url'
 
@@ -14,73 +21,7 @@ import { compile } from '../lib/register.js'
 
 const debug = debugFactory('@swc-node')
 
-const builtin = new Set([
-  '_http_agent',
-  '_http_client',
-  '_http_common',
-  '_http_incoming',
-  '_http_outgoing',
-  '_http_server',
-  '_stream_duplex',
-  '_stream_passthrough',
-  '_stream_readable',
-  '_stream_transform',
-  '_stream_wrap',
-  '_stream_writable',
-  '_tls_common',
-  '_tls_wrap',
-  'assert',
-  'assert/strict',
-  'async_hooks',
-  'buffer',
-  'child_process',
-  'cluster',
-  'console',
-  'constants',
-  'crypto',
-  'dgram',
-  'diagnostics_channel',
-  'dns',
-  'dns/promises',
-  'domain',
-  'events',
-  'fs',
-  'fs/promises',
-  'http',
-  'http2',
-  'https',
-  'inspector',
-  'module',
-  'net',
-  'os',
-  'path',
-  'path/posix',
-  'path/win32',
-  'perf_hooks',
-  'process',
-  'punycode',
-  'querystring',
-  'readline',
-  'repl',
-  'stream',
-  'stream/consumers',
-  'stream/promises',
-  'stream/web',
-  'string_decoder',
-  'sys',
-  'timers',
-  'timers/promises',
-  'tls',
-  'trace_events',
-  'tty',
-  'url',
-  'util',
-  'util/types',
-  'v8',
-  'vm',
-  'worker_threads',
-  'zlib',
-])
+const builtin = new Set(builtinModules)
 
 const tsconfig: ts.CompilerOptions = readDefaultTsConfig()
 tsconfig.module = ts.ModuleKind.ESNext
@@ -263,7 +204,7 @@ export const resolve: ResolveHook = async (specifier, context, nextResolve) => {
     return addShortCircuitSignal(await nextResolve(specifier))
   }
 
-  const { error, path } = await resolver.async(
+  const { error, path, moduleType } = await resolver.async(
     join(fileURLToPath(context.parentURL), '..'),
     specifier.startsWith('file:') ? fileURLToPath(specifier) : specifier,
   )
@@ -283,7 +224,12 @@ export const resolve: ResolveHook = async (specifier, context, nextResolve) => {
     return addShortCircuitSignal({
       ...context,
       url: url.href,
-      format: 'module',
+      format:
+        moduleType === 'module'
+          ? 'module'
+          : path.endsWith('cjs') || path.endsWith('cts') || moduleType === 'commonjs' || !moduleType
+            ? 'commonjs'
+            : 'module',
     })
   }
 

packages/integrate-module/src/index.ts

@@ -44,7 +44,7 @@
     "@swc-node/sourcemap-support": "^0.5.1",
     "colorette": "^2.0.20",
     "debug": "^4.3.5",
-    "oxc-resolver": "^1.9.2",
+    "oxc-resolver": "^1.10.0",
     "pirates": "^4.0.6",
     "tslib": "^2.6.3"
   },