Skip to content

Commit ae2766b

Browse files
authored
server: Use forked validator crate (#1570)
## Motivation The version of validator we were using depends on an old `idna`, and has a bug where it can panic in validation. ## Solution Because upgrading to v0.17+ is pretty involved, switch to our fork for now which fixes the panic and upgrades dependencies but is otherwise the same as v0.16.1.
2 parents 31aecfd + 19a656b commit ae2766b

File tree

3 files changed

+11
-24
lines changed

3 files changed

+11
-24
lines changed

deny.toml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,6 @@ ignore = [
1515
"RUSTSEC-2023-0071",
1616
# TODO: Wait for dependencies to upgrade off of proc-macro-error
1717
"RUSTSEC-2024-0370",
18-
# Doesn't affect us, we only use the vulnerable version through validator
19-
# and don't use that for any sensitive auth checks.
20-
# Details: https://github.com/svix/monorepo-private/issues/9541
21-
"RUSTSEC-2024-0421",
2218
]
2319

2420
[licenses]

server/Cargo.lock

Lines changed: 7 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

server/svix-server/Cargo.toml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,10 @@ opentelemetry = { version = "0.23.0", features = ["metrics"] }
4141
opentelemetry_sdk = { version = "0.23.0", features = ["rt-tokio"] }
4242
opentelemetry-http = "0.12.0"
4343
opentelemetry-otlp = { version = "0.16.0", features = ["metrics"] }
44-
validator = { version = "0.16.0", features = ["derive"] }
44+
# Forked version of 0.16 with a small fix and dependency upgrades, since we
45+
# haven't gotten around to doing a proper upgrade yet (0.17 is a large
46+
# rewrite with a barely-useful changelog)
47+
validator = { git = "https://github.com/svix/validator.git", rev = "aebdc34a4ed72524902ff6d63397b9c435b0578f", features = ["derive"] }
4548
jwt-simple = "0.11.6"
4649
ed25519-compact = "2.1.1"
4750
chrono = { version="0.4.26", features = ["serde"] }

0 commit comments

Comments
 (0)