Don't abort additional INSERTs when hitting first conflict

svenklemm · svenklemm · commit 3fe3165a43f6 · 2025-02-07T23:28:43.000+01:00
When an INSERT with ON CONFLICT DO NOTHING hits the first conflicts it would abort additional INSERTS following the INSERT triggering the DO NOTHING clause leading to missed INSERTs. Fixes timescale#7672
diff --git a/src/nodes/hypertable_modify.c b/src/nodes/hypertable_modify.c
@@ -728,7 +728,7 @@ ExecModifyTable(CustomScanState *cs_node, PlanState *pstate)
 			cds->skip_current_tuple = false;
 			if (node->ps.instrument)
 				node->ps.instrument->ntuples2++;
-			return NULL;
+			continue;
 		}
 
 		/* No more tuples to process? */

Original file line number	Diff line number	Diff line change
`@@ -728,7 +728,7 @@ ExecModifyTable(CustomScanState cs_node, PlanState pstate)`
`728`	`728`	`cds->skip_current_tuple = false;`
`729`	`729`	`if (node->ps.instrument)`
`730`	`730`	`node->ps.instrument->ntuples2++;`
`731`		`- return NULL;`
	`731`	`+ continue;`
`732`	`732`	`}`
`733`	`733`
`734`	`734`	`/* No more tuples to process? */`