Skip to content

Commit 8592914

Browse files
authored
fix: correctly handle falsy values of style directives in SSR mode (#11584)
fixes #11044
1 parent 72d493a commit 8592914

File tree

4 files changed

+20
-1
lines changed

4 files changed

+20
-1
lines changed

.changeset/long-owls-eat.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'svelte': patch
3+
---
4+
5+
fix: correctly handle falsy values of style directives in SSR mode

packages/svelte/src/runtime/internal/ssr.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ export function add_classes(classes) {
193193
/** @returns {string} */
194194
function style_object_to_string(style_object) {
195195
return Object.keys(style_object)
196-
.filter((key) => style_object[key])
196+
.filter((key) => style_object[key] != null && style_object[key] !== '')
197197
.map((key) => `${key}: ${escape_attribute_value(style_object[key])};`)
198198
.join(' ');
199199
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
export default {
2+
html: `
3+
<p style="--a: 0;"></p>
4+
<p style="--b: false;"></p>
5+
<p></p>
6+
<p></p>
7+
<p></p>
8+
`
9+
};
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<p style:--a={0}></p>
2+
<p style:--b={false}></p>
3+
<p style:--c=""></p>
4+
<p style:--d={undefined}></p>
5+
<p style:--e={null}></p>

0 commit comments

Comments
 (0)