fix: wrong AST and type due to newline after = to reactive variable (#234)

* fix: wrong AST and type due to newline after `=` to reactive variable

* Create tall-lions-invite.md

Author: ota-meshi

.changeset/tall-lions-invite.md

@@ -0,0 +1,5 @@
+---
+"svelte-eslint-parser": patch
+---
+
+fix: wrong AST and type due to newline after `=` to reactive variable

src/parser/typescript/analyze/index.ts

@@ -305,7 +305,11 @@ function transformForDeclareReactiveVar(
   ctx.skipUntilOriginalOffset(id.range[0]);
   ctx.appendVirtualScript("let ");
   ctx.appendOriginal(eq ? eq.range[1] : expression.right.range[0]);
-  ctx.appendVirtualScript(`${functionId}();\nfunction ${functionId}(){return `);
+  ctx.appendVirtualScript(
+    `${functionId}();\nfunction ${functionId}(){return (`
+  );
+  ctx.appendOriginal(expression.right.range[1]);
+  ctx.appendVirtualScript(`)`);
   for (const token of closeParens) {
     ctx.appendOriginal(token.range[0]);
     ctx.skipOriginalOffset(token.range[1] - token.range[0]);

tests/fixtures/integrations/type-info-tests/ts-newline-input.svelte

@@ -0,0 +1,14 @@
+<script lang="ts">
+$: aWithNewline =
+  42;
+$: bWithNewline =
+  42
+$: cWithNewline =
+  (42);
+$: dWithNewline =(
+  42)
+$: eWithNewline =
+  (42)
+</script>
+
+{aWithNewline}{bWithNewline}{cWithNewline}{dWithNewline}{eWithNewline}

tests/fixtures/integrations/type-info-tests/ts-newline-output.json

@@ -0,0 +1 @@
+[]

tests/fixtures/integrations/type-info-tests/ts-newline-setup.ts

@@ -0,0 +1,30 @@
+/* eslint eslint-comments/require-description: 0, @typescript-eslint/explicit-module-boundary-types: 0 */
+import type { Linter } from "eslint";
+import { BASIC_PARSER_OPTIONS } from "../../../src/parser/test-utils";
+import { rules } from "@typescript-eslint/eslint-plugin";
+export function setupLinter(linter: Linter) {
+  linter.defineRule(
+    "@typescript-eslint/no-confusing-void-expression",
+    rules["no-confusing-void-expression"] as never
+  );
+  linter.defineRule(
+    "@typescript-eslint/explicit-function-return-type",
+    rules["explicit-function-return-type"] as never
+  );
+}
+
+export function getConfig() {
+  return {
+    parser: "svelte-eslint-parser",
+    parserOptions: BASIC_PARSER_OPTIONS,
+    rules: {
+      "@typescript-eslint/no-confusing-void-expression": "error",
+      "@typescript-eslint/explicit-function-return-type": "error",
+      "no-unreachable": "error",
+    },
+    env: {
+      browser: true,
+      es2021: true,
+    },
+  };
+}

tests/fixtures/parser/ast/ts-newline-input.svelte

@@ -0,0 +1,15 @@
+<script lang="ts">
+$: aWithNewline =
+  42;
+$: bWithNewline =
+  42
+$: cWithNewline =
+  (42);
+$: dWithNewline =(
+  42)
+$: eWithNewline =
+  (42)
+</script>
+
+{aWithNewline}{bWithNewline}{cWithNewline}{dWithNewline}{eWithNewline}
+