The displayValue('questionName', {row.colName}) exoression no longer … #9702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…works and a selected choice's display text doesn't appear in a matrix cell fix #9699
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
packages/survey-core/src/question_checkbox.ts:70
- [nitpick] Double-check that returning an empty array when valuePropertyName is set meets the intended dependency resolution logic, to avoid inadvertently skipping required dependencies.
protected getDependedQuestionsByValueName(isDependOn: boolean): Array<IQuestion> {
Co-authored-by: Copilot <[email protected]>
tsv2013
approved these changes
Apr 8, 2025
andrewtelnov
added a commit
that referenced
this pull request
Apr 8, 2025
#9702) * The displayValue('questionName', {row.colName}) exoression no longer works and a selected choice's display text doesn't appear in a matrix cell fix #9699 * Update packages/survey-core/tests/question_matrixdynamictests.ts Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…works and a selected choice's display text doesn't appear in a matrix cell fix #9699