When survey.data contains a number in a string format and expression … #9693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…returns the same value as a number then survey response is not changed fix #9690
There was a problem hiding this comment.
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
packages/survey-core/tests/question_expressiontests.ts:335
- The error message in the assertion is misleading as it refers to the value as a string while it is expected to be a number. Consider updating the message to reflect that the value is a number.
assert.strictEqual(survey.getValue("q1"), 2, "survey.getValue('q1') is string", "
packages/survey-core/src/base.ts:1156
- Review whether setting doNotConvertNumbers to true here is intentional, as it might prevent the desired conversion of string numbers to number types, potentially conflicting with Bug#9690.
return Helpers.checkIfValuesEqual(x, y, { ignoreOrder: false, caseSensitive: !caseInSensitive, trimStrings: trimString, doNotConvertNumbers: true });
packages/survey-core/tests/surveytests.ts:19174
- [nitpick] Using an 'any' cast for 'menuType' may obscure underlying type issues. Consider using a more specific type or updating the options interface so that it naturally accepts a string.
options.menuType = <any>menuType;
tsv2013
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…returns the same value as a number then survey response is not changed fix #9690