Skip to content

Commit 3cc83e8

Browse files
author
tsv2013
committed
Advanced header is misaligned when static width is specified for a survey
Fixes #9715
1 parent 988e96a commit 3cc83e8

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

packages/survey-core/src/header.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,10 @@ export class Cover extends Base {
110110
}
111111
private updateContentClasses(): void {
112112
const surveyWidthMode = !!this.survey && this.survey.calculateWidthMode();
113-
this.maxWidth = this.inheritWidthFrom === "survey" && !!surveyWidthMode && surveyWidthMode === "static" && this.survey.renderedWidth;
113+
this.maxWidth = this.inheritWidthFrom === "survey" && !!surveyWidthMode && surveyWidthMode === "static" && this.survey.width;
114+
if (!!this.maxWidth) {
115+
this.maxWidth = parseFloat(this.maxWidth.toString().replace("px", "")) + "px";
116+
}
114117
this.contentClasses = new CssClassBuilder()
115118
.append("sv-header__content")
116119
.append("sv-header__content--static", this.inheritWidthFrom === "survey" && !!surveyWidthMode && surveyWidthMode === "static")

packages/survey-core/tests/headerTests.ts

+11
Original file line numberDiff line numberDiff line change
@@ -88,20 +88,31 @@ QUnit.test("contentClasses",
8888
cover.survey = new SurveyModel();
8989

9090
assert.equal(cover.inheritWidthFrom, "survey", "default inheritWidthFrom");
91+
assert.equal(cover.maxWidth, undefined, "default maxWidth");
9192

9293
cover.inheritWidthFrom = "container";
9394
assert.equal(cover.inheritWidthFrom, "container", "inheritWidthFrom");
9495
assert.equal(cover.contentClasses, "sv-header__content sv-header__content--responsive", "inheritWidthFrom is container");
96+
assert.equal(cover.maxWidth, "", "default maxWidth container");
9597

9698
cover.inheritWidthFrom = "survey";
9799
assert.equal(cover.survey.widthMode, "auto", "default widthMode");
98100
assert.equal(cover.contentClasses, "sv-header__content sv-header__content--static", "default contentClasses");
101+
assert.equal(cover.maxWidth, undefined, "default maxWidth survey");
99102

100103
cover.survey.widthMode = "responsive";
101104
assert.equal(cover.contentClasses, "sv-header__content sv-header__content--responsive", "survey.widthMode is responsive");
105+
assert.equal(cover.maxWidth, "", "default maxWidth survey responsible");
102106

103107
cover.survey.widthMode = "static";
104108
assert.equal(cover.contentClasses, "sv-header__content sv-header__content--static", "survey.widthMode is static");
109+
assert.equal(cover.maxWidth, undefined, "default maxWidth survey static");
110+
111+
cover.survey.width = "1200";
112+
assert.equal(cover.maxWidth, "1200px", "default maxWidth survey static number");
113+
114+
cover.survey.width = "1200px";
115+
assert.equal(cover.maxWidth, "1200px", "default maxWidth survey static px");
105116
}
106117
);
107118

0 commit comments

Comments
 (0)