update linter to 2.0.2

Author: strowk

.github/workflows/golangci-lint.yaml

@@ -18,5 +18,5 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.64.8
+          version: v2.0.2
           args: --timeout 5m

CONTRIBUTION.md

@@ -62,6 +62,17 @@ In addition to describing test case, you might need to setup some resources in K
 For how that could be done check methods such as `createPod` in [main_test.go](./main_test.go).
 You can either use `kubectl` command or `client-go` library to create and wait for initialization of resources before foxytest test runner starts.
 
+## Linting
+
+This project uses [golangci-lint](https://golangci-lint.run/) for linting.
+Version in use currently is `v2.0.2`.
+
+Once you have installed linter, you can run it with the following command:
+
+```bash
+golangci-lint run
+```
+
 ## Development
 
 You can run the project with automatic reload if you firstly install arelo:

internal/k8s/apps/v1/deployment/list_deployments.go

@@ -49,7 +49,7 @@ func ListDeployments(clientset kubernetes.Interface, namespace string) *mcp.Call
 		return deployments.Items[i].Namespace < deployments.Items[j].Namespace
 	})
 
-	var contents []interface{} = make([]interface{}, len(deployments.Items))
+	var contents = make([]interface{}, len(deployments.Items))
 	for i, deployment := range deployments.Items {
 		// Calculate age
 		age := time.Since(deployment.CreationTimestamp.Time)

internal/k8s/core/v1/pod/list_pods.go

@@ -24,7 +24,7 @@ func ListPods(clientset kubernetes.Interface, k8sNamespace string) *mcp.CallTool
 		return pods.Items[i].Name < pods.Items[j].Name
 	})
 
-	var contents []interface{} = make([]interface{}, len(pods.Items))
+	var contents = make([]interface{}, len(pods.Items))
 	for i, pod := range pods.Items {
 		content, err := content.NewJsonContent(PodInList{
 			Name:      pod.Name,

internal/k8s/core/v1/service/list_services.go

@@ -34,7 +34,7 @@ func ListServices(clientset kubernetes.Interface, k8sNamespace string) *mcp.Call
 		return services.Items[i].Name < services.Items[j].Name
 	})
 
-	var contents []interface{} = make([]interface{}, len(services.Items))
+	var contents = make([]interface{}, len(services.Items))
 	for i, service := range services.Items {
 		serviceContent := ServiceContent{
 			Name:        service.Name,

internal/prompts/namespaces.go

@@ -56,7 +56,7 @@ func NewListNamespacesPrompt(pool k8s.ClientPool) fxctx.Prompt {
 				ofContextMsg = fmt.Sprintf(", context '%s'", currentContext)
 			}
 
-			var messages []mcp.PromptMessage = make(
+			var messages = make(
 				[]mcp.PromptMessage,
 				len(namespaces.Items)+1,
 			)

internal/prompts/pods.go

@@ -60,7 +60,7 @@ func NewListPodsPrompt(pool k8s.ClientPool) fxctx.Prompt {
 				namespaceInMessage = fmt.Sprintf("namespace '%s'", k8sNamespace)
 			}
 
-			var messages []mcp.PromptMessage = make(
+			var messages = make(
 				[]mcp.PromptMessage,
 				len(pods.Items)+1,
 			)

internal/resources/contexts.go

@@ -49,7 +49,7 @@ func NewContextsResourceProvider() fxctx.ResourceProvider {
 					return nil, fmt.Errorf("context not found: %s", name)
 				}
 
-				var contents []interface{} = make([]interface{}, 1)
+				var contents = make([]interface{}, 1)
 				contents[0] = &struct {
 					Uri     string       `json:"uri"`
 					Text    string       `json:"text"`
@@ -85,7 +85,7 @@ func getContextsContent(uri string, cfg api.Config) []interface{} {
 		}
 	}
 
-	var contents []interface{} = make([]interface{}, allowedContextsCount)
+	var contents = make([]interface{}, allowedContextsCount)
 	i := 0
 
 	for name, c := range cfg.Contexts {

internal/tools/contexts.go

@@ -56,7 +56,7 @@ func getListContextsToolContent(cfg api.Config, current string) []interface{} {
 		}
 	}
 
-	var contents []interface{} = make([]interface{}, allowedContextsCount)
+	var contents = make([]interface{}, allowedContextsCount)
 	i := 0
 
 	for name, c := range cfg.Contexts {

internal/tools/events.go

@@ -59,7 +59,7 @@ func NewListEventsTool(pool k8s.ClientPool) fxctx.Tool {
 				return errResponse(err)
 			}
 
-			var contents []interface{} = make([]interface{}, len(events.Items))
+			var contents = make([]interface{}, len(events.Items))
 			for i, event := range events.Items {
 				eventInList := EventInList{
 					Action:  event.Action,

internal/tools/list_resources_tool.go

@@ -112,7 +112,7 @@ func NewListResourcesTool(pool k8s.ClientPool) fxctx.Tool {
 							return utils.ErrResponse(err)
 						}
 
-						var contents []interface{} = make([]interface{}, len(unstructured.Items))
+						var contents = make([]interface{}, len(unstructured.Items))
 						for i, item := range unstructured.Items {
 							// we try to list only metadata to avoid too big outputs
 							metadata, ok := item.Object["metadata"].(map[string]interface{})

internal/tools/namespaces.go

@@ -49,7 +49,7 @@ func NewListNamespacesTool(pool k8s.ClientPool) fxctx.Tool {
 				return namespace.Items[i].Name < namespace.Items[j].Name
 			})
 
-			var contents []interface{} = make([]interface{}, len(namespace.Items))
+			var contents = make([]interface{}, len(namespace.Items))
 			for i, namespace := range namespace.Items {
 				content, err := NewJsonContent(NamespacesInList{
 					Name: namespace.Name,

internal/tools/nodes.go

@@ -51,7 +51,7 @@ func NewListNodesTool(pool k8s.ClientPool) fxctx.Tool {
 				return nodes.Items[i].Name < nodes.Items[j].Name
 			})
 
-			var contents []interface{} = make([]interface{}, len(nodes.Items))
+			var contents = make([]interface{}, len(nodes.Items))
 			for i, ns := range nodes.Items {
 				// Calculate age
 				age := time.Since(ns.CreationTimestamp.Time)

internal/tools/pod_exec_cmd.go

@@ -115,7 +115,7 @@ func cmdExecuter(
 	}
 
 	if len(pod.Spec.Containers) == 0 {
-		return execResult, fmt.Errorf("Pod %s has no containers", podName)
+		return execResult, fmt.Errorf("pod %s has no containers", podName)
 	}
 
 	containerName := pod.Spec.Containers[0].Name

main_test.go

@@ -9,6 +9,7 @@ import (
 	"testing"
 	"time"
 
+	"github.com/stretchr/testify/require"
 	"github.com/strowk/foxy-contexts/pkg/foxytest"
 	"github.com/strowk/mcp-k8s-go/internal/k8s"
 
@@ -20,8 +21,8 @@ func TestListContexts(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	os.Setenv("KUBECONFIG", "./testdata/k8s_contexts/kubeconfig")
-	defer os.Unsetenv("KUBECONFIG")
+	require.NoError(t, os.Setenv("KUBECONFIG", "./testdata/k8s_contexts/kubeconfig"))
+	defer require.NoError(t, os.Unsetenv("KUBECONFIG"))
 	ts.WithExecutable("go", []string{"run", "main.go"})
 	cntrl := foxytest.NewTestRunner(t)
 	ts.Run(cntrl)
@@ -33,8 +34,8 @@ func TestWithAllowedContexts(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	os.Setenv("KUBECONFIG", "./testdata/k8s_contexts/kubeconfig")
-	defer os.Unsetenv("KUBECONFIG")
+	require.NoError(t, os.Setenv("KUBECONFIG", "./testdata/k8s_contexts/kubeconfig"))
+	defer require.NoError(t, os.Unsetenv("KUBECONFIG"))
 	ts.WithExecutable("go", []string{"run", "main.go", "--allowed-contexts=allowed-ctx"})
 	cntrl := foxytest.NewTestRunner(t)
 	ts.Run(cntrl)
@@ -188,7 +189,7 @@ func createK3dCluster(t *testing.T, name string) {
 }
 
 func saveKubeconfig(t *testing.T, name string) {
-	os.Setenv("KUBECONFIG", kubeconfigPath)
+	require.NoError(t, os.Setenv("KUBECONFIG", kubeconfigPath))
 
 	// write kubeconfig to file
 	data, err := exec.Command("k3d", "kubeconfig", "get", name).Output()