Skip to content

Commit 272799e

Browse files
prathmesh-stripeprathmesh-stripe
authored
Null out empty data sent to GET/DELETE APIs (#2172)
1 parent 16d137e commit 272799e

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

60 files changed

+176
-176
lines changed

‎src/StripeResource.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ StripeResource.prototype = {
178178
}
179179

180180
const dataInQuery = spec.method === 'GET' || spec.method === 'DELETE';
181-
const bodyData = dataInQuery ? {} : data;
181+
const bodyData = dataInQuery ? null : data;
182182
const queryData = dataInQuery ? data : {};
183183

184184
return {

‎src/Types.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ export type RequestOptions = {
6161
export type RequestOpts = {
6262
requestMethod: string;
6363
requestPath: string;
64-
bodyData: RequestData;
64+
bodyData: RequestData | null;
6565
queryData: RequestData;
6666
auth: string | null;
6767
headers: RequestHeaders;
@@ -155,7 +155,7 @@ export type RequestSender = {
155155
method: string,
156156
host: string | null,
157157
path: string,
158-
data: RequestData,
158+
data: RequestData | null,
159159
auth: string | null,
160160
options: RequestOptions,
161161
usage: Array<string>,

‎test/resources/Account.spec.js

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ describe('Account Resource', () => {
3333
expect(stripe.LAST_REQUEST).to.deep.equal({
3434
method: 'DELETE',
3535
url: '/v1/accounts/acct_16Tzq6DBahdM4C8s',
36-
data: {},
36+
data: null,
3737
headers: {},
3838
settings: {},
3939
});
@@ -59,7 +59,7 @@ describe('Account Resource', () => {
5959
expect(stripe.LAST_REQUEST).to.deep.equal({
6060
method: 'GET',
6161
url: '/v1/account',
62-
data: {},
62+
data: null,
6363
headers: {},
6464
settings: {},
6565
});
@@ -70,7 +70,7 @@ describe('Account Resource', () => {
7070
expect(stripe.LAST_REQUEST).to.deep.equal({
7171
method: 'GET',
7272
url: '/v1/accounts/foo',
73-
data: {},
73+
data: null,
7474
headers: {},
7575
settings: {},
7676
});
@@ -83,7 +83,7 @@ describe('Account Resource', () => {
8383
auth: key,
8484
method: 'GET',
8585
url: '/v1/account',
86-
data: {},
86+
data: null,
8787
headers: {},
8888
settings: {},
8989
});
@@ -96,7 +96,7 @@ describe('Account Resource', () => {
9696
auth: params.apiKey,
9797
method: 'GET',
9898
url: '/v1/account',
99-
data: {},
99+
data: null,
100100
headers: {},
101101
settings: {},
102102
});
@@ -107,7 +107,7 @@ describe('Account Resource', () => {
107107
expect(stripe.LAST_REQUEST).to.deep.equal({
108108
method: 'GET',
109109
url: '/v1/account',
110-
data: {},
110+
data: null,
111111
headers: {},
112112
settings: {},
113113
});
@@ -122,7 +122,7 @@ describe('Account Resource', () => {
122122
method: 'GET',
123123
url: '/v1/accounts/acct_123/capabilities',
124124
headers: {},
125-
data: {},
125+
data: null,
126126
settings: {},
127127
});
128128
});
@@ -133,7 +133,7 @@ describe('Account Resource', () => {
133133
method: 'GET',
134134
url: '/v1/accounts/acct_123/capabilities',
135135
headers: {},
136-
data: {},
136+
data: null,
137137
auth: TEST_AUTH_KEY,
138138
settings: {},
139139
});
@@ -147,7 +147,7 @@ describe('Account Resource', () => {
147147
method: 'GET',
148148
url: '/v1/accounts/acct_123/capabilities/acap_123',
149149
headers: {},
150-
data: {},
150+
data: null,
151151
settings: {},
152152
});
153153
});
@@ -162,7 +162,7 @@ describe('Account Resource', () => {
162162
method: 'GET',
163163
url: '/v1/accounts/acct_123/capabilities/acap_123',
164164
headers: {},
165-
data: {},
165+
data: null,
166166
auth: TEST_AUTH_KEY,
167167
settings: {},
168168
});
@@ -216,7 +216,7 @@ describe('Account Resource', () => {
216216
url:
217217
'/v1/accounts/accountIdFoo321/external_accounts/externalAccountIdFoo456',
218218
headers: {},
219-
data: {},
219+
data: null,
220220
settings: {},
221221
});
222222
});
@@ -232,7 +232,7 @@ describe('Account Resource', () => {
232232
url:
233233
'/v1/accounts/accountIdFoo321/external_accounts/externalAccountIdFoo456',
234234
headers: {},
235-
data: {},
235+
data: null,
236236
auth: TEST_AUTH_KEY,
237237
settings: {},
238238
});
@@ -307,7 +307,7 @@ describe('Account Resource', () => {
307307
url:
308308
'/v1/accounts/accountIdFoo321/external_accounts/externalAccountIdFoo456',
309309
headers: {},
310-
data: {},
310+
data: null,
311311
settings: {},
312312
});
313313
});
@@ -323,7 +323,7 @@ describe('Account Resource', () => {
323323
url:
324324
'/v1/accounts/accountIdFoo321/external_accounts/externalAccountIdFoo456',
325325
headers: {},
326-
data: {},
326+
data: null,
327327
auth: TEST_AUTH_KEY,
328328
settings: {},
329329
});
@@ -337,7 +337,7 @@ describe('Account Resource', () => {
337337
method: 'GET',
338338
url: '/v1/accounts/accountIdFoo321/external_accounts',
339339
headers: {},
340-
data: {},
340+
data: null,
341341
settings: {},
342342
});
343343
});
@@ -348,7 +348,7 @@ describe('Account Resource', () => {
348348
method: 'GET',
349349
url: '/v1/accounts/accountIdFoo321/external_accounts',
350350
headers: {},
351-
data: {},
351+
data: null,
352352
auth: TEST_AUTH_KEY,
353353
settings: {},
354354
});
@@ -379,7 +379,7 @@ describe('Account Resource', () => {
379379
method: 'GET',
380380
url: '/v1/accounts/acct_123/persons/person_123',
381381
headers: {},
382-
data: {},
382+
data: null,
383383
settings: {},
384384
});
385385
});
@@ -390,7 +390,7 @@ describe('Account Resource', () => {
390390
method: 'GET',
391391
url: '/v1/accounts/acct_123/persons/person_123',
392392
headers: {},
393-
data: {},
393+
data: null,
394394
auth: TEST_AUTH_KEY,
395395
settings: {},
396396
});
@@ -471,7 +471,7 @@ describe('Account Resource', () => {
471471
method: 'DELETE',
472472
url: '/v1/accounts/acct_123/persons/person_123',
473473
headers: {},
474-
data: {},
474+
data: null,
475475
settings: {},
476476
});
477477
});
@@ -482,7 +482,7 @@ describe('Account Resource', () => {
482482
method: 'DELETE',
483483
url: '/v1/accounts/acct_123/persons/person_123',
484484
headers: {},
485-
data: {},
485+
data: null,
486486
auth: TEST_AUTH_KEY,
487487
settings: {},
488488
});
@@ -496,7 +496,7 @@ describe('Account Resource', () => {
496496
method: 'GET',
497497
url: '/v1/accounts/acct_123/persons',
498498
headers: {},
499-
data: {},
499+
data: null,
500500
settings: {},
501501
});
502502
});
@@ -507,7 +507,7 @@ describe('Account Resource', () => {
507507
method: 'GET',
508508
url: '/v1/accounts/acct_123/persons',
509509
headers: {},
510-
data: {},
510+
data: null,
511511
auth: TEST_AUTH_KEY,
512512
settings: {},
513513
});

‎test/resources/ApplePayDomains.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ describe('ApplePayDomains Resource', () => {
1111
method: 'GET',
1212
url: '/v1/apple_pay/domains/apwc_retrieve',
1313
headers: {},
14-
data: {},
14+
data: null,
1515
settings: {},
1616
});
1717
});
@@ -24,7 +24,7 @@ describe('ApplePayDomains Resource', () => {
2424
method: 'DELETE',
2525
url: '/v1/apple_pay/domains/apwc_delete',
2626
headers: {},
27-
data: {},
27+
data: null,
2828
settings: {},
2929
});
3030
});
@@ -55,7 +55,7 @@ describe('ApplePayDomains Resource', () => {
5555
method: 'GET',
5656
url: '/v1/apple_pay/domains',
5757
headers: {},
58-
data: {},
58+
data: null,
5959
settings: {},
6060
});
6161
});

‎test/resources/ApplicationFees.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ describe('ApplicationFee Resource', () => {
1010
expect(stripe.LAST_REQUEST).to.deep.equal({
1111
method: 'GET',
1212
url: '/v1/application_fees',
13-
data: {},
13+
data: null,
1414
headers: {},
1515
settings: {},
1616
});
@@ -50,7 +50,7 @@ describe('ApplicationFee Resource', () => {
5050
expect(stripe.LAST_REQUEST).to.deep.equal({
5151
method: 'GET',
5252
url: '/v1/application_fees/appFeeIdExample3242/refunds',
53-
data: {},
53+
data: null,
5454
headers: {},
5555
settings: {},
5656
});
@@ -65,7 +65,7 @@ describe('ApplicationFee Resource', () => {
6565
method: 'GET',
6666
url:
6767
'/v1/application_fees/appFeeIdExample3242/refunds/refundIdExample2312',
68-
data: {},
68+
data: null,
6969
headers: {},
7070
settings: {},
7171
});

‎test/resources/Balance.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ describe('Balance Resource', () => {
1010
expect(stripe.LAST_REQUEST).to.deep.equal({
1111
method: 'GET',
1212
url: '/v1/balance',
13-
data: {},
13+
data: null,
1414
headers: {},
1515
settings: {},
1616
});
@@ -21,7 +21,7 @@ describe('Balance Resource', () => {
2121
expect(stripe.LAST_REQUEST).to.deep.equal({
2222
method: 'GET',
2323
url: '/v1/balance',
24-
data: {},
24+
data: null,
2525
auth: 'aGN0bIwXnHdw5645VABjPdSn8nWY7G11',
2626
headers: {},
2727
settings: {},

‎test/resources/BalanceTransactions.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ describe('BalanceTransactions Resource', function() {
1111
method: 'GET',
1212
url: '/v1/balance_transactions/txn_123',
1313
headers: {},
14-
data: {},
14+
data: null,
1515
settings: {},
1616
});
1717
});
@@ -24,7 +24,7 @@ describe('BalanceTransactions Resource', function() {
2424
method: 'GET',
2525
url: '/v1/balance_transactions',
2626
headers: {},
27-
data: {},
27+
data: null,
2828
settings: {},
2929
});
3030
});

‎test/resources/BillingPortal/Configurations.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ describe('BillingPortal', () => {
5252
method: 'GET',
5353
url: '/v1/billing_portal/configurations/bpc_123',
5454
headers: {},
55-
data: {},
55+
data: null,
5656
settings: {},
5757
});
5858
});
@@ -64,7 +64,7 @@ describe('BillingPortal', () => {
6464
method: 'GET',
6565
url: '/v1/billing_portal/configurations',
6666
headers: {},
67-
data: {},
67+
data: null,
6868
settings: {},
6969
});
7070
});

‎test/resources/Charges.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ describe('Charge Resource', () => {
1010
expect(stripe.LAST_REQUEST).to.deep.equal({
1111
method: 'GET',
1212
url: '/v1/charges/chargeIdFoo123',
13-
data: {},
13+
data: null,
1414
headers: {},
1515
settings: {},
1616
});
@@ -52,7 +52,7 @@ describe('Charge Resource', () => {
5252
expect(stripe.LAST_REQUEST).to.deep.equal({
5353
method: 'GET',
5454
url: '/v1/charges',
55-
data: {},
55+
data: null,
5656
headers: {},
5757
settings: {},
5858
});

‎test/resources/Checkout/Sessions.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ describe('Checkout', () => {
4545
expect(stripe.LAST_REQUEST).to.deep.equal({
4646
method: 'GET',
4747
url: '/v1/checkout/sessions/cs_123',
48-
data: {},
48+
data: null,
4949
headers: {},
5050
settings: {},
5151
});
@@ -59,7 +59,7 @@ describe('Checkout', () => {
5959
method: 'GET',
6060
url: '/v1/checkout/sessions/cs_123/line_items',
6161
headers: {},
62-
data: {},
62+
data: null,
6363
settings: {},
6464
});
6565
});

‎test/resources/CountrySpecs.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ describe('CountrySpecs Resource', () => {
1010
expect(stripe.LAST_REQUEST).to.deep.equal({
1111
method: 'GET',
1212
url: '/v1/country_specs',
13-
data: {},
13+
data: null,
1414
headers: {},
1515
settings: {},
1616
});
@@ -24,7 +24,7 @@ describe('CountrySpecs Resource', () => {
2424
expect(stripe.LAST_REQUEST).to.deep.equal({
2525
method: 'GET',
2626
url: `/v1/country_specs/${country}`,
27-
data: {},
27+
data: null,
2828
headers: {},
2929
settings: {},
3030
});

0 commit comments

Comments
 (0)