Skip to content

Commit df23eb3

Browse files
committed
better way how to label namespaces
Signed-off-by: Lukas Kral <[email protected]>
1 parent 534540b commit df23eb3

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

systemtest/src/test/java/io/strimzi/systemtest/AbstractST.java

+14-9
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import io.skodjob.testframe.resources.JobType;
1313
import io.skodjob.testframe.resources.KubeResourceManager;
1414
import io.skodjob.testframe.resources.NamespaceType;
15+
import io.skodjob.testframe.utils.KubeUtils;
1516
import io.strimzi.systemtest.exceptions.KubernetesClusterUnstableException;
1617
import io.strimzi.systemtest.interfaces.IndicativeSentences;
1718
import io.strimzi.systemtest.logs.TestExecutionWatcher;
@@ -46,9 +47,7 @@
4647
import org.junit.jupiter.api.extension.ExtensionContext;
4748

4849
import java.util.Collections;
49-
import java.util.HashMap;
5050
import java.util.List;
51-
import java.util.Map;
5251

5352
import static io.strimzi.systemtest.matchers.Matchers.logHasNoUnexpectedErrors;
5453
import static io.strimzi.test.k8s.KubeClusterResource.cmdKubeClient;
@@ -84,17 +83,23 @@ public abstract class AbstractST implements TestSeparator {
8483

8584
KubeResourceManager.get().addCreateCallback(resource -> {
8685
if (resource instanceof Namespace namespace) {
87-
Map<String, String> labels = new HashMap<>(namespace.getMetadata().getLabels());
88-
labels.put(TestConstants.TEST_SUITE_NAME_LABEL, StUtils.removePackageName(KubeResourceManager.get().getTestContext().getRequiredTestClass().getName()));
86+
String testClass = StUtils.removePackageName(KubeResourceManager.get().getTestContext().getRequiredTestClass().getName());
87+
88+
KubeUtils.labelNamespace(
89+
namespace.getMetadata().getName(),
90+
TestConstants.TEST_SUITE_NAME_LABEL,
91+
testClass
92+
);
8993

9094
if (KubeResourceManager.get().getTestContext().getTestMethod().isPresent()) {
9195
String testCaseName = KubeResourceManager.get().getTestContext().getRequiredTestMethod().getName();
92-
labels.put(TestConstants.TEST_CASE_NAME_LABEL, testCaseName);
93-
}
9496

95-
namespace.getMetadata().setLabels(labels);
96-
97-
KubeResourceManager.get().kubeClient().getClient().resource(namespace).update();
97+
KubeUtils.labelNamespace(
98+
namespace.getMetadata().getName(),
99+
TestConstants.TEST_CASE_NAME_LABEL,
100+
testCaseName
101+
);
102+
}
98103
}
99104
});
100105
}

0 commit comments

Comments
 (0)