chore: Upgrade ES Lint (#3500)

Author: Jason3S

eslint.config.js

@@ -1,9 +1,7 @@
-/* eslint-disable n/no-unpublished-import */
 // @ts-check
 
 import eslint from '@eslint/js';
 import nodePlugin from 'eslint-plugin-n';
-import eslintPluginPrettierRecommended from 'eslint-plugin-prettier/recommended';
 import simpleImportSort from 'eslint-plugin-simple-import-sort';
 import tsEslint from 'typescript-eslint';
 
@@ -15,7 +13,6 @@ import tsEslint from 'typescript-eslint';
 export default tsEslint.config(
     eslint.configs.recommended,
     nodePlugin.configs['flat/recommended'],
-    eslintPluginPrettierRecommended,
     ...tsEslint.configs.recommended,
     ...tsEslint.configs.strict,
     ...tsEslint.configs.stylistic,

package-lock.json

@@ -3983,7 +3983,7 @@
     "build-website": "cd website && npm i && npm run build",
     "gen-docs": "npm --workspace=@internal/docs run gen-docs",
     "package-extension": "vsce package --pre-release -o ./build",
-    "prettier:check": "prettier \"**/*.{ts,tsx,js,json,md,svelte}\" -c",
+    "prettier:check": "prettier . -c",
     "prettier:fix": "npm run prettier:check -- -w",
     "prettier:fix-schema": "prettier -w \"**/*.schema.json\"",
     "test-vsce-build": "shx mkdir -p temp && vsce package -o ./temp/code-spell-checker.vsix",
@@ -4013,14 +4013,8 @@
     "chokidar-cli": "^3.0.0",
     "concurrently": "^8.2.2",
     "esbuild": "^0.23.0",
-    "eslint": "^8.57.0",
-    "eslint-config-prettier": "^9.1.0",
-    "eslint-import-resolver-typescript": "^3.6.1",
-    "eslint-plugin-import": "^2.29.1",
+    "eslint": "^9.8.0",
     "eslint-plugin-n": "^17.10.1",
-    "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-prettier": "^5.2.1",
-    "eslint-plugin-promise": "^7.0.0",
     "eslint-plugin-simple-import-sort": "^12.1.1",
     "eslint-plugin-unicorn": "^55.0.0",
     "globals": "^15.9.0",

package.json

@@ -1,4 +1,3 @@
-/* eslint-disable n/no-unpublished-import */
 export type { OnSpellCheckDocumentStep } from '../../_server/dist/api.js';
 export type { CSpellClient } from '../../client/dist/client/index.mjs';
 export type { ExtensionApi } from '../../client/dist/extensionApi.mjs';

packages/_integrationTests/src/ExtensionApi.mts

@@ -60,7 +60,7 @@ const cspellConfigInVsCode: CSpellUserSettings = {
 const sampleFiles = {
     sampleClientEsLint: Path.resolve(pathWorkspaceRoot, 'packages/client/.eslintrc.js'),
     sampleClientReadme: Path.resolve(pathWorkspaceRoot, 'packages/client/README.md'),
-    sampleNodePackage: require.resolve('yargs'),
+    sampleNodePackage: require.resolve('eslint'),
     sampleSamplesReadme: Path.resolve(pathWorkspaceRoot, 'samples/custom-dictionary/README.md'),
     sampleServerCSpell: Path.resolve(pathWorkspaceRoot, 'packages/_server/cspell.json'),
     sampleServerPackageLock: Path.resolve(pathWorkspaceRoot, 'packages/_server/package-lock.json'),

packages/_server/src/config/documentSettings.test.mts

@@ -42,7 +42,8 @@
   "devDependencies": {
     "ts-loader": "^9.5.1",
     "webpack": "^5.93.0",
-    "webpack-cli": "^5.1.4"
+    "webpack-cli": "^5.1.4",
+    "yargs": "^17.7.2"
   },
   "dependencies": {
     "@cspell/cspell-types": "^8.13.1",

packages/_serverPatternMatcher/package.json

@@ -1,5 +1,3 @@
 /* eslint-disable @typescript-eslint/no-require-imports */
-/* eslint-disable n/no-extraneous-require */
-/* eslint-disable @typescript-eslint/no-var-requires */
-/* eslint-disable no-undef */
+
 module.exports = require('jest-mock-vscode').createVSCodeMock(jest);

packages/client/src/__mocks__/vscode.js

@@ -1,6 +1,5 @@
 import type { ProviderResult, TreeItem } from 'vscode';
 
-// eslint-disable-next-line @typescript-eslint/no-extraneous-class
 export abstract class IssueTreeItemBase {
     abstract getTreeItem(): TreeItem | Promise<TreeItem>;
     abstract getChildren(): ProviderResult<IssueTreeItemBase[]>;

packages/client/src/issueViewer/IssueTreeItemBase.ts

@@ -1,5 +1,4 @@
 import type { ParseArgsConfig } from 'node:util';
-// eslint-disable-next-line n/no-unsupported-features/node-builtins
 import { parseArgs } from 'node:util';
 
 import assert from 'assert';

packages/client/src/repl/args.mts

@@ -1,6 +1,5 @@
 import assert from 'node:assert';
 import type { ParseArgsConfig } from 'node:util';
-// eslint-disable-next-line n/no-unsupported-features/node-builtins
 import { parseArgs } from 'node:util';
 
 import { describe, expect, test } from 'vitest';

packages/client/src/repl/args.test.mts

@@ -4,4 +4,4 @@ categories: docs
 # parent: Docs
 sidebar_position: 1
 sidebar_label: Getting Started
----
+---

website/docs/getting-started.mdx

@@ -4,20 +4,20 @@
  */
 
 .heroBanner {
-  padding: 4rem 0;
-  text-align: center;
-  position: relative;
-  overflow: hidden;
+    padding: 4rem 0;
+    text-align: center;
+    position: relative;
+    overflow: hidden;
 }
 
 @media screen and (max-width: 996px) {
-  .heroBanner {
-    padding: 2rem;
-  }
+    .heroBanner {
+        padding: 2rem;
+    }
 }
 
 .buttons {
-  display: flex;
-  align-items: center;
-  justify-content: center;
+    display: flex;
+    align-items: center;
+    justify-content: center;
 }