Skip to content

Commit 81baa44

Browse files
street-side-software-automation[bot]Jason3S
street-side-software-automation[bot]
and
Jason3S
authored
ci: Fix Lint -- Workflow Bot (#5642)
Co-authored-by: Jason3S <[email protected]>
1 parent 27b8b9a commit 81baa44

File tree

18 files changed

+45
-45
lines changed

18 files changed

+45
-45
lines changed

‎packages/cspell-eslint-plugin/src/worker/spellCheck.mts

+2-2
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,7 @@ async function reportConfigurationErrors(config: CSpellSettings, knownConfigErro
471471
const key = ref.error.toString();
472472
if (knownConfigErrors.has(key)) return;
473473
knownConfigErrors.add(key);
474-
errors.push(Error('Configuration Error: \n ' + ref.error.message));
474+
errors.push(new Error('Configuration Error: \n ' + ref.error.message));
475475
});
476476

477477
const dictCollection = await getDictionary(config);
@@ -483,7 +483,7 @@ async function reportConfigurationErrors(config: CSpellSettings, knownConfigErro
483483
if (knownConfigErrors.has(key)) return;
484484
knownConfigErrors.add(key);
485485
const errMsg = `${msg}: ${error.message}\n Source: ${dict.source}`;
486-
errors.push(Error(errMsg));
486+
errors.push(new Error(errMsg));
487487
});
488488
});
489489

‎packages/cspell-io/src/VirtualFs.test.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -147,21 +147,21 @@ describe('VirtualFs', () => {
147147
test('try unsupported readFile', async () => {
148148
const fs = virtualFs.fs;
149149
const result = fs.readFile(new URL('ftp://example.com/data.json'));
150-
await expect(result).rejects.toEqual(Error('Unsupported request: readFile'));
150+
await expect(result).rejects.toEqual(new Error('Unsupported request: readFile'));
151151
await expect(result).rejects.toBeInstanceOf(VFSErrorUnsupportedRequest);
152152
});
153153

154154
test('try unsupported stat', async () => {
155155
const fs = virtualFs.fs;
156156
const result = fs.stat(new URL('ftp://example.com/data.json'));
157-
await expect(result).rejects.toEqual(Error('Unsupported request: stat'));
157+
await expect(result).rejects.toEqual(new Error('Unsupported request: stat'));
158158
await expect(result).rejects.toBeInstanceOf(VFSErrorUnsupportedRequest);
159159
});
160160

161161
test('try unsupported readDirectory', async () => {
162162
const fs = virtualFs.fs;
163163
const result = fs.readDirectory(new URL('ftp://example.com/data.json'));
164-
await expect(result).rejects.toEqual(Error('Unsupported request: readDirectory'));
164+
await expect(result).rejects.toEqual(new Error('Unsupported request: readDirectory'));
165165
await expect(result).rejects.toBeInstanceOf(VFSErrorUnsupportedRequest);
166166
});
167167

‎packages/cspell-io/src/errors/error.test.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ import { toError } from './error.js';
55
describe('errors', () => {
66
test.each`
77
err | expected
8-
${Error('test')} | ${Error('test')}
9-
${{ message: 'test' }} | ${Error('test')}
10-
${'test'} | ${Error('test')}
11-
${undefined} | ${Error()}
8+
${new Error('test')} | ${new Error('test')}
9+
${{ message: 'test' }} | ${new Error('test')}
10+
${'test'} | ${new Error('test')}
11+
${undefined} | ${new Error()}
1212
`('toError $err', ({ err, expected }) => {
1313
expect(toError(err)).toEqual(expected);
1414
});

‎packages/cspell-io/src/errors/error.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ export function toError(e: unknown): Error {
44
return new Error(e.message, { cause: e });
55
}
66
// eslint-disable-next-line @typescript-eslint/no-explicit-any
7-
return Error(e && (e as any).toString());
7+
return new Error(e && (e as any).toString());
88
}

‎packages/cspell-io/src/node/file/FetchError.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ describe('FetchError', () => {
3333

3434
test.each`
3535
err | expected
36-
${new Error('Not good')} | ${Error('Not good')}
37-
${'hello'} | ${Error('Unknown Error')}
36+
${new Error('Not good')} | ${new Error('Not good')}
37+
${'hello'} | ${new Error('Unknown Error')}
3838
`('toError', ({ err, expected }) => {
3939
expect(toError(err)).toEqual(expected);
4040
});

‎packages/cspell-io/src/node/file/FetchError.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,5 +55,5 @@ export function toFetchUrlError(err: unknown, url: URL): FetchUrlError {
5555
}
5656

5757
export function toError(err: unknown): Error {
58-
return err instanceof Error ? err : Error('Unknown Error', { cause: err });
58+
return err instanceof Error ? err : new Error('Unknown Error', { cause: err });
5959
}

‎packages/cspell-lib/src/lib/Settings/Controller/configLoader/configLoader.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -768,7 +768,7 @@ describe('ConfigLoader with VirtualFS', () => {
768768

769769
expect(configFile).toBeInstanceOf(Error);
770770
assert(configFile instanceof Error);
771-
expect(configFile.cause).toEqual(Error(`Untrusted URL: "${location?.href}"`));
771+
expect(configFile.cause).toEqual(new Error(`Untrusted URL: "${location?.href}"`));
772772
});
773773
});
774774

‎packages/cspell-lib/src/lib/util/errors.test.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@ describe('errors', () => {
5858
});
5959

6060
test.each`
61-
err | expected
62-
${Error('hello')} | ${Error('hello')}
63-
${'hello'} | ${Error('hello')}
64-
${'hello'} | ${expect.any(UnknownError)}
61+
err | expected
62+
${new Error('hello')} | ${new Error('hello')}
63+
${'hello'} | ${new Error('hello')}
64+
${'hello'} | ${expect.any(UnknownError)}
6565
`('toError', ({ err, expected }) => {
6666
expect(toError(err)).toEqual(expected);
6767
});

‎packages/cspell-service-bus/src/SystemServiceBus.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ describe('SystemServiceBus Behavior', () => {
7676
${RequestFsReadFile.create({ uri: 'file://my_file.txt' })} | ${{ value: 'read file: file://my_file.txt' }}
7777
${RequestFsReadFile.create({ uri: 'https://www.example.com/my_file.txt' })} | ${{ value: 'fetch http: https://www.example.com/my_file.txt' }}
7878
${RequestFsReadFile.create({ uri: 'https://www.example.com/my_dict.trie.gz' })} | ${{ value: 'Inflate: fetch http: https://www.example.com/my_dict.trie.gz' }}
79-
${{ type: 'zlib:compress' }} | ${{ error: Error('Unhandled Request: zlib:compress') }}
79+
${{ type: 'zlib:compress' }} | ${{ error: new Error('Unhandled Request: zlib:compress') }}
8080
`('dispatch requests', ({ request, expected }) => {
8181
expect(serviceBus.dispatch(request)).toEqual(expected);
8282
});

‎packages/cspell-service-bus/src/assert.test.ts

+7-7
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ describe('assert', () => {
1616
${true} | ${undefined} | ${undefined}
1717
${1} | ${undefined} | ${undefined}
1818
${'yes'} | ${undefined} | ${undefined}
19-
${undefined} | ${undefined} | ${Error('AssertionError')}
20-
${0} | ${undefined} | ${Error('AssertionError')}
21-
${null} | ${undefined} | ${Error('AssertionError')}
22-
${''} | ${undefined} | ${Error('AssertionError')}
23-
${false} | ${undefined} | ${Error('AssertionError')}
24-
${false} | ${'Must be true or fail'} | ${Error('Must be true or fail')}
25-
${false} | ${Error('my error')} | ${Error('my error')}
19+
${undefined} | ${undefined} | ${new Error('AssertionError')}
20+
${0} | ${undefined} | ${new Error('AssertionError')}
21+
${null} | ${undefined} | ${new Error('AssertionError')}
22+
${''} | ${undefined} | ${new Error('AssertionError')}
23+
${false} | ${undefined} | ${new Error('AssertionError')}
24+
${false} | ${'Must be true or fail'} | ${new Error('Must be true or fail')}
25+
${false} | ${new Error('my error')} | ${new Error('my error')}
2626
`('compare assert to node assert $value / $message', ({ value, message, expected }) => {
2727
expect(catchError(() => assert(value, message))).toEqual(expected);
2828
});

‎packages/cspell-service-bus/src/assert.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
export function assert(value: unknown, message?: string | Error): asserts value {
22
if (!value) {
3-
const err = message instanceof Error ? message : Error(message ?? 'AssertionError');
3+
const err = message instanceof Error ? message : new Error(message ?? 'AssertionError');
44
throw err;
55
}
66
}

‎packages/cspell-service-bus/src/bus.test.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,9 @@ describe('Service Bus', () => {
9595
${FibRequestFactory.create({ fib: 7 })} | ${response(13)}
9696
${StringLengthRequestFactory.create({ str: 'hello' })} | ${response(5)}
9797
${new StringToUpperRequest('hello')} | ${response('HELLO')}
98-
${new DoNotHandleRequest()} | ${{ error: Error('Unhandled Request: Do Not Handle') }}
99-
${new RetryAgainRequest()} | ${{ error: Error('Service Request Depth 10 Exceeded: Retry Again Request') }}
100-
${new ServiceRequestCls('throw', undefined)} | ${{ error: Error('Unhandled Error in Handler: handlerThrowErrorOnRequest') }}
98+
${new DoNotHandleRequest()} | ${{ error: new Error('Unhandled Request: Do Not Handle') }}
99+
${new RetryAgainRequest()} | ${{ error: new Error('Service Request Depth 10 Exceeded: Retry Again Request') }}
100+
${new ServiceRequestCls('throw', undefined)} | ${{ error: new Error('Unhandled Error in Handler: handlerThrowErrorOnRequest') }}
101101
`('serviceBus handle request: $request.type', ({ request, expected }) => {
102102
expect(bus.dispatch(request)).toEqual(expected);
103103
});

‎packages/cspell-tools/src/shasum/shasum.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -78,14 +78,14 @@ describe('shasum', () => {
7878
expect(result.passed).toBe(false);
7979
expect(result.results.filter((r) => !r.passed)).toHaveLength(1);
8080
const missingResult = result.results[0];
81-
expect(missingResult.error).toEqual(Error('Failed to read file.'));
81+
expect(missingResult.error).toEqual(new Error('Failed to read file.'));
8282
});
8383

8484
test('checkShasumFile bad format', async () => {
8585
const root = resolvePathToFixture('dicts');
8686
const filename = resolvePathToFixture('dicts/_checksum-bad-format.txt');
8787
await expect(checkShasumFile(filename, [], root)).rejects.toEqual(
88-
Error('Failed to parse line 3 of checksum file.'),
88+
new Error('Failed to parse line 3 of checksum file.'),
8989
);
9090
});
9191

‎packages/cspell-tools/src/shasum/shasum.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -59,15 +59,15 @@ export async function checkShasumFile(
5959

6060
async function tryToCheckFile(filename: string, root: string, checksum: string | undefined): Promise<CheckFileResult> {
6161
if (!checksum) {
62-
return { filename, passed: false, error: Error('Missing Checksum.') };
62+
return { filename, passed: false, error: new Error('Missing Checksum.') };
6363
}
6464

6565
const file = resolve(root, filename);
6666
try {
6767
const passed = await checkFile(checksum, file);
6868
return { filename, passed };
6969
} catch {
70-
return { filename, passed: false, error: Error('Failed to read file.') };
70+
return { filename, passed: false, error: new Error('Failed to read file.') };
7171
}
7272
}
7373

‎packages/cspell-tools/src/util/errors.test.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ describe('errors', () => {
1414

1515
test.each`
1616
err | expected
17-
${1} | ${Error('1')}
18-
${undefined} | ${Error('undefined')}
19-
${new Error('hello')} | ${Error('hello')}
20-
${{ name: 'Err' }} | ${Error('[object Object]')}
17+
${1} | ${new Error('1')}
18+
${undefined} | ${new Error('undefined')}
19+
${new Error('hello')} | ${new Error('hello')}
20+
${{ name: 'Err' }} | ${new Error('[object Object]')}
2121
`('toError', ({ err, expected }) => {
2222
expect(toError(err)).toEqual(expected);
2323
});

‎packages/cspell/src/app/util/reporters.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ describe('mergeReporters', () => {
4242

4343
test.each`
4444
reporter | expected
45-
${['@cspell/cspell-json-reporter', false]} | ${Error('Failed to load reporter @cspell/cspell-json-reporter: cspell-json-reporter settings must be an object')}
45+
${['@cspell/cspell-json-reporter', false]} | ${new Error('Failed to load reporter @cspell/cspell-json-reporter: cspell-json-reporter settings must be an object')}
4646
${['@cspell/cspell-unknown-reporter']} | ${oc({ message: sc("Failed to load reporter @cspell/cspell-unknown-reporter: Cannot find package '@cspell/cspell-unknown-reporter' imported from") })}
4747
${'@cspell/cspell-unknown-reporter'} | ${oc({ message: sc("Failed to load reporter @cspell/cspell-unknown-reporter: Cannot find package '@cspell/cspell-unknown-reporter'") })}
4848
`('loadReporters fail $reporter', async ({ reporter, expected }) => {

‎test-packages/cspell-service-bus/test-cspell-service-bus-esm/src/index.test.mts

+3-3
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ describe('Service Bus', () => {
2121
${FibRequestFactory.create({ fib: 7 })} | ${createResponse(13)}
2222
${StringLengthRequestFactory.create({ str: 'hello' })} | ${createResponse(5)}
2323
${new StringToUpperRequest('hello')} | ${createResponse('HELLO')}
24-
${new DoNotHandleRequest()} | ${{ error: Error('Unhandled Request: Do Not Handle') }}
25-
${new RetryAgainRequest()} | ${{ error: Error('Service Request Depth 10 Exceeded: Retry Again Request') }}
26-
${new ServiceRequestCls('throw', undefined)} | ${{ error: Error('Unhandled Error in Handler: handlerThrowErrorOnRequest') }}
24+
${new DoNotHandleRequest()} | ${{ error: new Error('Unhandled Request: Do Not Handle') }}
25+
${new RetryAgainRequest()} | ${{ error: new Error('Service Request Depth 10 Exceeded: Retry Again Request') }}
26+
${new ServiceRequestCls('throw', undefined)} | ${{ error: new Error('Unhandled Error in Handler: handlerThrowErrorOnRequest') }}
2727
`('serviceBus handle request: $request.type', ({ request, expected }) => {
2828
expect(bus.dispatch(request)).toEqual(expected);
2929
});

‎test-packages/cspell-service-bus/test-cspell-service-bus-rollup/src/index.test.mts

+3-3
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ describe('Service Bus', () => {
2121
${FibRequestFactory.create({ fib: 7 })} | ${createResponse(13)}
2222
${StringLengthRequestFactory.create({ str: 'hello' })} | ${createResponse(5)}
2323
${new StringToUpperRequest('hello')} | ${createResponse('HELLO')}
24-
${new DoNotHandleRequest()} | ${{ error: Error('Unhandled Request: Do Not Handle') }}
25-
${new RetryAgainRequest()} | ${{ error: Error('Service Request Depth 10 Exceeded: Retry Again Request') }}
26-
${new ServiceRequestCls('throw', undefined)} | ${{ error: Error('Unhandled Error in Handler: handlerThrowErrorOnRequest') }}
24+
${new DoNotHandleRequest()} | ${{ error: new Error('Unhandled Request: Do Not Handle') }}
25+
${new RetryAgainRequest()} | ${{ error: new Error('Service Request Depth 10 Exceeded: Retry Again Request') }}
26+
${new ServiceRequestCls('throw', undefined)} | ${{ error: new Error('Unhandled Error in Handler: handlerThrowErrorOnRequest') }}
2727
`('serviceBus handle request: $request.type', ({ request, expected }) => {
2828
expect(bus.dispatch(request)).toEqual(expected);
2929
});

0 commit comments

Comments
 (0)