Add option to configure CDN serving GraphiQL files

[parth-paradkar]

Feature Request Type

• Core functionality
• Alteration (enhancement/optimization) of existing feature(s)
• New behavior

Description

Can we add an option to override the default unkpg.com CDN serving the GraphiQL IDE? (given the recent issues)-

graphql/graphiql#3877
unpkg/unpkg#412
unpkg/unpkg#443

Users may want to use another CDN in such incidents.

[patrick91]

@parth-paradkar it's not too difficult to update the GraphiQL template already, no?

I fear that adding another config would make the template more complex for not much gain 😊

[parth-paradkar]

I see, no worries. Thanks!

[caspervk]

@patrick91 what do you think about vendoring dependencies with strawberry instead of relying on a cdn?

[patrick91]

@caspervk I think we thought about that, but each framework has it's own way to handle static files, I don't there's a nice way to handle them generically 🤔

[caspervk]

Right, it's annoying because there are no static files - it's just a html string through get_graphql_ide_html. To keep it a single file you could in-line the dependencies directly in the html - that'd perhaps be okay for GraphiQL, but I don't know how much css/js the other IDEs pull.

[caspervk]

How about something like

def get_graphql_ide_html(
    graphql_ide: Optional[GraphQL_IDE] = "graphiql",
) -> str:
    here = pathlib.Path(__file__).parents[1]

    if graphql_ide == "apollo-sandbox":
        path = here / "static/apollo-sandbox.html"
    elif graphql_ide == "pathfinder":
        path = here / "static/pathfinder.html"
    else:
        path = here / "static/graphiql.html"
 
-    return path.read_text(encoding="utf-8")
+    template = path.read_text(encoding="utf-8")
+
+    template = template.replace(
+        "{{ graphiql.min.css }}",
+        (here / "static/vendor/graphiql.min.css").read_text(encoding="utf-8"),
+    )
+    template = template.replace(
+        "{{ graphiql.min.js }}",
+        (here / "static/vendor/graphiql.min.js").read_text(encoding="utf-8"),
+    )
+
+    return template

or is it too dumb 😅