Ignore Android end transaction error when closing

for androidDatabaseProvider: 'system' setting,
to avoid possible crash during app shutdown

(cordova-sqlite-storage 2.5.2)

Resolves #833

Author: Christopher J. Brody

CHANGES.md

@@ -1,5 +1,9 @@
 # Changes
 
+### cordova-sqlite-storage 2.5.2
+
+- Ignore Android end transaction error when closing for androidDatabaseProvider: 'system' setting, to avoid possible crash during app shutdown (<https://github.com/litehelpers/Cordova-sqlite-storage/issues/833>)
+
 ### cordova-sqlite-storage 2.5.1
 
 - fix internal plugin cleanup error log on Android

package.json

@@ -1,6 +1,6 @@
 {
   "name": "cordova-sqlite-storage",
-  "version": "2.5.1",
+  "version": "2.5.2",
   "description": "Native interface to SQLite for PhoneGap/Cordova",
   "cordova": {
     "id": "cordova-sqlite-storage",

plugin.xml

@@ -2,7 +2,7 @@
 <plugin xmlns="http://www.phonegap.com/ns/plugins/1.0"
     xmlns:android="http://schemas.android.com/apk/res/android"
     id="cordova-sqlite-storage"
-    version="2.5.1">
+    version="2.5.2">
 
     <name>Cordova sqlite storage plugin</name>
 

src/android/io/sqlc/SQLiteAndroidDatabase.java

@@ -80,7 +80,12 @@ void open(File dbfile) throws Exception {
     void closeDatabaseNow() {
         if (mydb != null) {
             if (isTransactionActive) {
-                mydb.endTransaction();
+                try {
+                    mydb.endTransaction();
+                } catch (Exception ex) {
+                    Log.v("closeDatabaseNow", "INTERNAL PLUGIN ERROR IGNORED: Not able to end active transaction before closing database: " + ex.getMessage());
+                    ex.printStackTrace();
+                }
                 isTransactionActive = false;
             }
             mydb.close();